Skip to content

Move MQR changes to cfamily only. (CPP-6672) #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

frederic-tingaud-sonarsource
Copy link
Contributor

No description provided.

@frederic-tingaud-sonarsource
Copy link
Contributor Author

The moves were done manually, so it might deserve a good check before validating.

@alejandro-alvarez-sonarsource
Copy link
Member

I have done the following: fae62e1 is the commit before our merge.

git diff fae62e1b9fb8e57eaf12e59d9d6edad24dfdef69 --stat | grep -oP "rules/S\d+/metadata.json"

I see only files from 3bd7eea, so shared files are reverted to the previous state.

I have also gone over the diff view, and it looks good to me.

The following rules had only formatting changes, unless I am mistaken: S1134, S2193, S2245, S2259, S2589, S2612, S2681 S4423, S4426, S4790, S4830, S5042, S5332, S5443, S5527, S5542, S5547, S5802, S5847, S5849,

S942 was removed, and remains removed. Since the metadata.json was empty, I assume this is OK.

Shouldn't we add someone from TS and/or JVM to double check?

Copy link
Contributor

@loic-joly-sonarsource loic-joly-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not perform formatting-only changes in this PR.
Here is my list: S1134 S2193 S2245 S2259 S2589 S2612 S2681 S4423 S4426 S4790 S4830 S5042 S5332 S5443 S5527 S5542 S5547 S5802 S5847 S5849, it's identical to the one from @alejandro-alvarez-sonarsource

1 real change

Copy link

sonarqube-next bot commented Jul 9, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Jul 9, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@loic-joly-sonarsource loic-joly-sonarsource changed the title Move MQR changes to cfamily only. Move MQR changes to cfamily only. (CPP-6672) Jul 9, 2025
@loic-joly-sonarsource loic-joly-sonarsource added this pull request to the merge queue Jul 9, 2025
Merged via the queue into master with commit a3eb5b3 Jul 9, 2025
12 of 13 checks passed
@loic-joly-sonarsource loic-joly-sonarsource deleted the ft/revert-shared-security branch July 9, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cfamily C / C++ / Objective-C common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants