-
Notifications
You must be signed in to change notification settings - Fork 31
Move MQR changes to cfamily only. (CPP-6672) #5185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The moves were done manually, so it might deserve a good check before validating. |
I have done the following: fae62e1 is the commit before our merge. git diff fae62e1b9fb8e57eaf12e59d9d6edad24dfdef69 --stat | grep -oP "rules/S\d+/metadata.json" I see only files from 3bd7eea, so shared files are reverted to the previous state. I have also gone over the diff view, and it looks good to me. The following rules had only formatting changes, unless I am mistaken: S1134, S2193, S2245, S2259, S2589, S2612, S2681 S4423, S4426, S4790, S4830, S5042, S5332, S5443, S5527, S5542, S5547, S5802, S5847, S5849, S942 was removed, and remains removed. Since the Shouldn't we add someone from TS and/or JVM to double check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not perform formatting-only changes in this PR.
Here is my list: S1134 S2193 S2245 S2259 S2589 S2612 S2681 S4423 S4426 S4790 S4830 S5042 S5332 S5443 S5527 S5542 S5547 S5802 S5847 S5849, it's identical to the one from @alejandro-alvarez-sonarsource
1 real change
Co-authored-by: Loïc Joly <[email protected]>
|
|
No description provided.