Skip to content

[Snyk] Security upgrade gatsby from 5.14.0 to 5.14.2 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

St0nersdash
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-6147607
  626  
medium severity Cross-site Scripting (XSS)
SNYK-JS-WEBPACK-7840298
  616  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @St0nersdash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the gatsby dependency from version 5.14.0 to 5.14.2 to address two medium severity Cross-site Scripting (XSS) vulnerabilities. The changes include modifications to package.json to update the gatsby version and updates to yarn.lock to reflect the updated dependencies and their resolved versions. Specifically, several @webassemblyjs and other related packages are updated, and some older versions are removed from yarn.lock.

Highlights

  • Security Upgrade: Upgrades gatsby from 5.14.0 to 5.14.2 to fix two XSS vulnerabilities.
  • Dependency Updates: Updates multiple dependencies in yarn.lock, including @webassemblyjs packages, to their latest versions.
  • Yarn Lock Changes: Removes older versions of several packages from yarn.lock to ensure consistency and security.

Changelog

Click here to see the changelog
  • package.json
    • Upgraded gatsby dependency from version 5.14.0 to 5.14.2.
  • yarn.lock
    • Updated versions of multiple dependencies, including @types/eslint-scope, @types/estree, and @webassemblyjs packages.
    • Removed older versions of packages like @types/eslint-scope@^3.7.3, @types/estree@^1.0.0, @webassemblyjs/[email protected], and others.
    • Modified integrity hashes for updated packages.
    • Updated gatsby-graphiql-explorer from 3.14.0 to 3.14.1
    • Updated gatsby-link from 5.14.0 to 5.14.1
    • Updated gatsby from 5.14.0 to 5.14.3
    • Updated webpack from ^5.88.1 to ~5.98.0
    • Removed browserslist@^4.14.5
    • Removed schema-utils@^3.2.0
    • Removed terser-webpack-plugin@^5.3.7
    • Removed terser@^5.16.5
    • Removed watchpack@^2.4.0
    • Removed webpack@^5.88.1
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A lockfile's tale,
A version bump to prevail,
Security's call,
Fixing for all,
No XSS to wail.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the gatsby dependency from version 5.14.0 to 5.14.2, along with some related dependencies in yarn.lock, to address two medium severity XSS vulnerabilities. The changes appear to be straightforward dependency updates.

Merge Readiness

The pull request addresses two medium severity vulnerabilities, which is a positive step. Given the nature of the changes (dependency upgrades), it's important to ensure that these upgrades don't introduce any regressions or breaking changes in the project. While I cannot directly approve this pull request, I recommend that the changes be thoroughly tested to confirm that the application functions as expected after the upgrade. If tests pass and no regressions are found, the pull request should be safe to merge.

Comment on lines +7957 to +7960
gatsby@^5.14.2:
version "5.14.3"
resolved "https://registry.yarnpkg.com/gatsby/-/gatsby-5.14.3.tgz#3d4111002766c40cf097aee46c4ee2f18a9058f2"
integrity sha512-eAF9qWfAI/EDnuLjOVlRRjp2oy+2kApxOlIehcUrDtgR/mrOIvw6H9sJfiqumB7vuPV4wO//iy+K6SBY433EEg==

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version of gatsby is updated here, but the resolved version is 5.14.3, not 5.14.2 as indicated in package.json. This discrepancy should be investigated to ensure the correct version is being used.

gatsby@^5.14.2:
  version "5.14.2"

Comment on lines 7 to +10
"@docsearch/js": "3.5.2",
"@fec/gatsby-plugin-advanced-feed": "^3.0.1",
"@reach/router": "^1.1.1",
"gatsby": "^5.14.0",
"gatsby": "^5.14.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change updates the gatsby dependency to version 5.14.2. It's good to see the project being kept up-to-date with security patches.

    "gatsby": "^5.14.2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants