Skip to content

Adding a gradio demo of SVD to be run locally #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 21, 2024
Merged

Adding a gradio demo of SVD to be run locally #144

merged 5 commits into from
Feb 21, 2024

Conversation

yvrjsharma
Copy link
Contributor

added gradio_app.py, updated requirements/pt2.txt and readme.md for relevant libraries and information respectively

akx
akx reviewed Nov 22, 2023
View reviewed changes
@timudk
Copy link
Contributor

timudk commented Nov 22, 2023

Awesome thank you so much @yvrjsharma!! This is amazing and so fast!

Before merging I have a couple of requests:

  • add gradio to reqs (and remove fire, uuid as @akx suggested)
  • only download ckpt if not already present (it redownloaded it for me)
  • it would be nice to add options for all models (instead of only svd-xt), it's optional but if not we should rename the file
  • fps_id should be an int (but slider is float)
  • a lot of code seems to be copy & pasted from simple_video_sample, can we instead just import functions we need?

@sumith1896
Copy link
Contributor

@yvrjsharma thanks for the PR! Could you please address @timudk's comments from above and let us know? One of us will have look (cc @AK391)

@yvrjsharma
Copy link
Contributor Author

yvrjsharma commented Feb 12, 2024 •
edited
Loading

Hi, @timudk @sumith1896, sincere apologies I couldn't come back to this thread any earlier due to various reasons.
I have addressed all the comments from above. Thanks for the detailed comments and for following up on this! Let me know if this PR needs anything else from my side. This PR now supports the latest SVD 1.1 as well.

sumith1896
sumith1896 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@sumith1896 sumith1896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried locally and works, thanks for the PR @yvrjsharma!

@timudk timudk merged commit 1e30a2d into Stability-AI:main Feb 21, 2024
@yvrjsharma
Copy link
Contributor Author

Awesome, thanks for the merge @sumith1896 !

LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
@yvrjsharma @sumith1896 @LinearFalcon
Adding a gradio demo of SVD to be run locally (Stability-AI#144)
6c93b36 
* Adding a gradio demo of SVD to be run locally

* Update gradio_app.py

* Create svd_xt_1_1.yaml

* Update pt2.txt

---------

Co-authored-by: Sumith Kulal <[email protected]>
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
@yvrjsharma @sumith1896
Adding a gradio demo of SVD to be run locally (Stability-AI#144)
28c802e 
* Adding a gradio demo of SVD to be run locally

* Update gradio_app.py

* Create svd_xt_1_1.yaml

* Update pt2.txt

---------

Co-authored-by: Sumith Kulal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx left review comments

@sumith1896 sumith1896 sumith1896 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yvrjsharma @timudk @sumith1896 @akx