Setup an experimental SMACS repository to allow tooling scripts testing #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-sadakhom
commented
May 23, 2025
| ./gradlew clean build | ||
| ./gradlew build |
There was a problem hiding this comment.
the clean task is unnecessary and will slow down build time
justin-sadakhom
commented
May 23, 2025
| @@ -38,6 +38,7 @@ fragment IssueFragment on Issue { | |||
| # No need to get all pages as issues don't realistically have >100 | |||
| connectedPrs(first: 5) { | |||
| nodes { | |||
| id | |||
There was a problem hiding this comment.
PR id is needed to add / remove a connection to an issue
justin-sadakhom
commented
May 23, 2025
src/main/kotlin/zenhub/Pipeline.kt
Outdated
There was a problem hiding this comment.
the pipeline ids were hardcoded to our main zenhub board, which was problematic when we wanted to switch to using the test board for e2e / integration tests. ideally our github-zenhub-sdk code is agnostic to which board is being used, so this has been moved to ziro-cli
justin-sadakhom
commented
May 23, 2025
Comment on lines
-18
to
-28
| @Test | ||
| fun whenGetIssuesByPipelineThenAtLeastZeroIssues() { | ||
| val issues = zenHubClient.getIssuesByPipeline(Pipeline.MERGE_READY) | ||
|
|
||
| if (issues.isNotEmpty()) { | ||
| assertTrue(issues[0].issueFragment.number > 0) | ||
| } else { | ||
| assertNotNull(issues) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
this test isn't really usefull... it's not even a unit test (not fully mocked)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.