Skip to content

RSSP-1975: Add unit tests for GhCustomSpeeds #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericabertugli
Copy link

@ericabertugli ericabertugli commented Aug 8, 2024

This PR is not making any change to the code.

I'm just adding 2 unit tests that reproduce the current behavior of GraphhopperCustomSpeeds:

  • custom speed is discarded when > max_speed for that vehicle (30 kmh for bikes, 254 kmh for cars)
  • custom speed is discarded when > max_speed by osm_way_id.

In both cases, the default speed defined in the custom profile is used.

Jira Ticket

RSSP-1975

@ericabertugli ericabertugli marked this pull request as ready for review August 8, 2024 15:57
@ericabertugli ericabertugli requested a review from HDBandit August 8, 2024 15:58
Copy link

sonarqubecloud bot commented Aug 8, 2024

@ericabertugli ericabertugli requested a review from tyoras August 12, 2024 09:17
Copy link

@tyoras tyoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ericabertugli ericabertugli merged commit 63ea993 into develop Aug 12, 2024
6 checks passed
@ericabertugli ericabertugli deleted the feature/RSPS-1975_add_unit_tests_for_custom_speeds branch August 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants