Skip to content

[RSPS-2011]: Fix speed too high bug #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

jp-lopez
Copy link

@jp-lopez jp-lopez commented Sep 10, 2024

Jira Ticket

RSPS-2011

Implementation details

Fix bug when we load a map with custom speeds, close it and the load the same map another time.
When do it GH is not using the correct max_speed for that transport.

We found that the problem was that GH once import the OSM file it stores the max_speed property of the speed encoder in a property file. And because we are setting the custom speeds after that, if we un load and reload the map GH will use the value store in that properties file.

To solve it after import the custom speed we need to save the encoder values another time in the properties files.

Testing

I add a test simulating that behaviour.

Copy link

Copy link

@tyoras tyoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job finding and fixing this bug 🚀
Does the changes related to the pom version update are meant to be committed in this PR?

edit: It seems this PR is targeting master when it should be develop that's why there are some extra commits in it.

@jp-lopez
Copy link
Author

Close because is pointing to master instead of develop

@jp-lopez jp-lopez closed this Sep 10, 2024
@jp-lopez jp-lopez deleted the bug/RSPS-2011_Speed_To_High_Bug branch September 10, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants