[Admin] Adjust payment method views #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoResponseMate
force-pushed
the
SYL-4676/admin-payment-method-view
branch
from
d5e719a to
c6c61dd
Compare
[Admin][PaymentMethod] Extract custom help messages to separate form theme blocks
[Admin][PaymentMethod] Fix info and version notifications placement
NoResponseMate
force-pushed
the
SYL-4676/admin-payment-method-view
branch
from
c6c61dd to
16c981d
Compare
Wojdylak
reviewed
May 14, 2025
| priority: 300 | ||
| api_key_live: | ||
| template: '@SyliusMolliePlugin/admin/payment_method/form/sections/gateway_configuration/credentials/api_key_live.html.twig' | ||
| priority: 200 |
There was a problem hiding this comment.
Suggested change
| priority: 200 | |
| priority: 100 |
| priority: 300 | ||
| api_key_live: | ||
| template: '@SyliusMolliePlugin/admin/payment_method/form/sections/gateway_configuration/credentials/api_key_live.html.twig' | ||
| priority: 200 |
There was a problem hiding this comment.
Suggested change
| priority: 200 | |
| priority: 100 |
| @@ -0,0 +1,5 @@ | |||
| {% set form = hookable_metadata.context.form.gatewayConfig.config.api_key_live %} | |||
|
|
|||
| {% form_theme form '@SyliusMolliePlugin/admin/payment_method/form/form_theme.html.twig' %} | |||
There was a problem hiding this comment.
Could you move this to the main twig file instead of importing it in multiple places?
There was a problem hiding this comment.
Unfortunately the block names for forms are pretty much generic, it's prefixed as _sylius_admin_payment_method_gatewayConfig_config_ with no indicator as to what factory/gateway the config relates to, so adding the theme globally can potentially conflict with other payment providers.
| {% hook 'item' %} | ||
| </div> | ||
| {% else %} | ||
| {% include '@SyliusMolliePlugin/admin/payment_method/form/sections/gateway_configuration/mollie_payment_methods/body/accordion/no_results.html.twig' %} |
There was a problem hiding this comment.
Maybe we should add a no_results hook. https://github.com/Sylius/Sylius/blob/2.1/src/Sylius/Bundle/ShopBundle/Resources/config/app/twig_hooks/checkout/select_shipping.yaml#L40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.