Skip to content

[ProductBundlePlugin] Add rules for 1.0 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions config/sets/sylius/product-bundle-plugin/product-bundle-plugin.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Sylius\SyliusRector\Rector\Class_\AddInterfaceToClassExtendingTypeRector;
use Sylius\SyliusRector\Rector\Class_\AddMethodCallToConstructorForClassesUsingTraitRector;
use Sylius\SyliusRector\Rector\Class_\AddTraitToClassExtendingTypeRector;
use Sylius\SyliusRector\Rector\Dto\AddMethodCallToConstructorForClassesUsingTrait;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->ruleWithConfiguration(AddInterfaceToClassExtendingTypeRector::class, [
'Sylius\Component\Core\Model\OrderItem' => ['Sylius\ProductBundlePlugin\Entity\OrderItemInterface'],
'Sylius\Component\Core\Model\Product' => ['Sylius\ProductBundlePlugin\Entity\ProductInterface'],
]);
$rectorConfig->ruleWithConfiguration(AddTraitToClassExtendingTypeRector::class, [
'Sylius\Component\Core\Model\OrderItem' => ['Sylius\ProductBundlePlugin\Entity\ProductBundleOrderItemsAwareTrait'],
'Sylius\Component\Core\Model\Product' => ['Sylius\ProductBundlePlugin\Entity\ProductBundlesAwareTrait'],
]);
$rectorConfig->ruleWithConfiguration(AddMethodCallToConstructorForClassesUsingTraitRector::class, [
'Sylius\ProductBundlePlugin\Entity\ProductBundleOrderItemsAwareTrait' => [
new AddMethodCallToConstructorForClassesUsingTrait('this', 'initializeProductBundleOrderItems'),
],
]);
};
10 changes: 10 additions & 0 deletions src/Set/SyliusProductBundle.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

declare(strict_types=1);

namespace Sylius\SyliusRector\Set;

final class SyliusProductBundle
{
public const PRODUCT_BUNDLE = __DIR__ . '/../../config/sets/sylius/product-bundle-plugin/product-bundle-plugin.php';
}
11 changes: 11 additions & 0 deletions stubs/Sylius/ProductBundlePlugin/Entity/OrderItemInterface.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

declare(strict_types=1);

if (class_exists('Sylius\ProductBundlePlugin\Entity\OrderItemInterface')) {
return;
}

interface OrderItemInterface
{
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

namespace Sylius\ProductBundlePlugin\Entity;

if (trait_exists('Sylius\ProductBundlePlugin\Entity\ProductBundleOrderItemsAwareTrait')) {
return;
}

trait ProductBundleOrderItemsAwareTrait
{
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

namespace Sylius\ProductBundlePlugin\Entity;

if (trait_exists('Sylius\ProductBundlePlugin\Entity\ProductBundlesAwareTrait')) {
return;
}

trait ProductBundlesAwareTrait
{
}
11 changes: 11 additions & 0 deletions stubs/Sylius/ProductBundlePlugin/Entity/ProductInterface.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

declare(strict_types=1);

if (class_exists('Sylius\ProductBundlePlugin\Entity\ProductInterface')) {
return;
}

interface ProductInterface
{
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

namespace Sylius\SyliusRector\Tests\Rector\Class_\AddInterfaceToClassExtendingType\Fixture;

use Sylius\Component\Core\Model\OrderItem as BaseOrderItem;

class OrderItem extends BaseOrderItem
{
}

?>
-----
<?php

namespace Sylius\SyliusRector\Tests\Rector\Class_\AddInterfaceToClassExtendingType\Fixture;

use Sylius\Component\Core\Model\OrderItem as BaseOrderItem;

class OrderItem extends BaseOrderItem implements \Sylius\ProductBundlePlugin\Entity\OrderItemInterface
{
use \Sylius\ProductBundlePlugin\Entity\ProductBundleOrderItemsAwareTrait;
public function __construct()
{
parent::__construct();
$this->initializeProductBundleOrderItems();
}
}

?>
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php

namespace Sylius\SyliusRector\Tests\Rector\Class_\AddInterfaceToClassExtendingType\Fixture;

use Sylius\Component\Core\Model\Product as BaseProduct;

class Product extends BaseProduct
{
}

?>
-----
<?php

namespace Sylius\SyliusRector\Tests\Rector\Class_\AddInterfaceToClassExtendingType\Fixture;

use Sylius\Component\Core\Model\Product as BaseProduct;

class Product extends BaseProduct implements \Sylius\ProductBundlePlugin\Entity\ProductInterface
{
use \Sylius\ProductBundlePlugin\Entity\ProductBundlesAwareTrait;
}

?>
31 changes: 31 additions & 0 deletions tests/Set/ProductBundlePlugin/ProductBundlePluginTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

declare(strict_types=1);

namespace Sylius\SyliusRector\Tests\Set\ProductBundlePlugin;

use Rector\Testing\PHPUnit\AbstractRectorTestCase;

final class ProductBundlePluginTest extends AbstractRectorTestCase
{
/**
* @dataProvider provideData()
*/
public function test(string $file): void
{
$this->doTestFile($file);
}

/**
* @return \Iterator<string>
*/
public function provideData(): \Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
}

public function provideConfigFilePath(): string
{
return __DIR__ . '/config/configured_rule.php';
}
}
11 changes: 11 additions & 0 deletions tests/Set/ProductBundlePlugin/config/configured_rule.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Sylius\SyliusRector\Set\SyliusProductBundle;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->import(__DIR__ . '/../../../../config/config.php');
$rectorConfig->sets([SyliusProductBundle::PRODUCT_BUNDLE]);
};
Loading