fix(runtime): vote program conformance #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadepo
reviewed
May 5, 2025
Rexicon226
requested changes
May 6, 2025
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
yewman
force-pushed
the
harnew/vote_program_conformance
branch
from
e4b737d to
b6eb376
Compare
Rexicon226
approved these changes
May 7, 2025
dadepo
reviewed
May 8, 2025
src/bincode/varint.zig
Outdated
| @@ -126,9 +126,12 @@ pub fn visit_byte_2(elem: u8, val: u16, nth_byte: usize) !DoneOrMore { | |||
| return error.ByteThreeContinues; | |||
| } | |||
|
|
|||
| const shift: u32 = (std.math.cast(u32, nth_byte) orelse U32_MAX) *| 7; | |||
| const shift = std.math.cast( | |||
There was a problem hiding this comment.
This is mainly for understanding the scope of the changes...
where this specific diffs needed to attain the conformance?
or these were other improvement identified but not specifically needed for the conformance
| } | ||
| }; | ||
|
|
||
| const CircBufV1 = struct { |
There was a problem hiding this comment.
Looks like the tests were dropped. Since this is still in draft, adding it back might be something still planned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for vote conformance