refactor(consensus, forkchoice) Add forkchoice.heaviestSlotOnSameVotedFork method

[dadepo]

This adds the implementation for heaviestSlotOnSameVotedFork.

This could not be implemented until now because it depends on Tower.

[dadepo]

The Agave version has two tests. One was implemented. The second test depends on heaviest_subtree_fork_choice.add_votes which was not implemented until now because it depends on input retrieved from Bank.

The heaviest_subtree_fork_choice.add_votes method can now be implemented, and would be done in a follow up PR. This is still possible even though there is no direct Bank struct, the convention of passing in the exact inputs directly would be followed (instead of via a Bank) and in this case the epoch_stakes and epoch_schedule.

[codecov]

Codecov Report

Attention: Patch coverage is 90.16393% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/consensus/fork_choice.zig	90.16%	6 Missing ⚠️

Files with missing lines	Coverage Δ
src/consensus/replay_tower.zig	85.69% <ø> (+0.41%)	⬆️
src/consensus/fork_choice.zig	89.85% <90.16%> (+0.02%)	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dadepo]

The second test depends on heaviest_subtree_fork_choice.add_votes which was not implemented until now because it depends on input retrieved from Bank

Further look into heaviest_subtree_fork_choice.add_votes shows it is only used in tests and in a struct called RepairWeight that has not popped up yet for implementation. In the meantime I manually added tests that covers the other code paths in the new code.