Skip to content

fix(svm): cpi conformance #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025
Merged

fix(svm): cpi conformance #730

merged 11 commits into from
May 22, 2025

Conversation

kprotty
Copy link
Contributor

@kprotty kprotty commented May 9, 2025

Fix cpi syscalls to pass conformance tests. Paired with Syndica/sig-fuzz#8

@kprotty kprotty self-assigned this May 9, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig May 9, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/vm/syscalls/cpi.zig 96.77% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/runtime/executor.zig 94.29% <100.00%> (-0.02%) ⬇️
src/vm/syscalls/lib.zig 87.67% <ø> (+1.98%) ⬆️
src/vm/syscalls/cpi.zig 90.26% <96.77%> (+3.78%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kprotty kprotty marked this pull request as ready for review May 12, 2025 17:05
@kprotty kprotty marked this pull request as draft May 14, 2025 13:50
@kprotty kprotty force-pushed the king/cpi-conformance branch 2 times, most recently from 6b41723 to 9982e1b Compare May 15, 2025 20:27
@kprotty kprotty marked this pull request as ready for review May 15, 2025 20:43
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig May 16, 2025
yewman
yewman previously approved these changes May 21, 2025
Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kprotty kprotty force-pushed the king/cpi-conformance branch from b8052d2 to ed18e1e Compare May 22, 2025 04:07
@kprotty kprotty added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit 0e2e3f0 May 22, 2025
17 checks passed
@kprotty kprotty deleted the king/cpi-conformance branch May 22, 2025 12:06
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Sig May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants