Skip to content

bincode: remove redundant code #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bincode: remove redundant code #772

wants to merge 1 commit into from

Conversation

alichraghi
Copy link

Closes #260

@alichraghi alichraghi requested review from ultd, dnut and yewman as code owners June 6, 2025 01:00
@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Jun 6, 2025
@Rexicon226 Rexicon226 self-requested a review June 6, 2025 14:34
Rexicon226
Rexicon226 approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@Rexicon226 Rexicon226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rexicon226 Rexicon226 Rexicon226 approved these changes

@ultd ultd Awaiting requested review from ultd ultd is a code owner

@dnut dnut Awaiting requested review from dnut dnut is a code owner

@yewman yewman Awaiting requested review from yewman yewman is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Sig
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bincode.varint is redundant and not well named
2 participants
@alichraghi @Rexicon226