Skip to content

test(svelte-query/useIsFetching): switch to fake timers, add 'expect', 'vi.waitFor', and replace 'findByText' with 'getByText' #9386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(svelte-query/useIsFetching): switch to fake timers, add 'expect', 'vi.waitFor', and replace 'findByText' with 'getByText' #9386

wants to merge 1 commit into from

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jul 7, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 173687f

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 46s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-07 10:04:14 UTC

@sukvvon sukvvon force-pushed the test/svelte-query-useIsFetching-fake-timers-vi-waitFor branch from 6542ab1 to 629e197 Compare July 7, 2025 09:47
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 7, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9386

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9386

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9386

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9386

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9386

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9386

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9386

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9386

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9386

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9386

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9386

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9386

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9386

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9386

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9386

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9386

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9386

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9386

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9386

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9386

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9386

commit: 173687f

@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (ed8cc23) to head (173687f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9386       +/-   ##
===========================================
+ Coverage   45.37%   89.53%   +44.15%     
===========================================
  Files         207       18      -189     
  Lines        8277      172     -8105     
  Branches     1865       31     -1834     
===========================================
- Hits         3756      154     -3602     
+ Misses       4080       17     -4063     
+ Partials      441        1      -440
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query 88.07% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sukvvon sukvvon marked this pull request as draft July 7, 2025 09:53
@sukvvon sukvvon force-pushed the test/svelte-query-useIsFetching-fake-timers-vi-waitFor branch from 629e197 to d55a903 Compare July 7, 2025 09:57
@sukvvon sukvvon changed the title test(svelte-query/useIsFetching): switch to fake timers, add 'vi.waitFor' and 'expect' test(svelte-query/useIsFetching): switch to fake timers, add 'vi.waitFor', and 'expect' Jul 7, 2025
@sukvvon sukvvon force-pushed the test/svelte-query-useIsFetching-fake-timers-vi-waitFor branch from d55a903 to d8190c3 Compare July 7, 2025 09:58
@sukvvon sukvvon marked this pull request as ready for review July 7, 2025 09:58
@sukvvon sukvvon changed the title test(svelte-query/useIsFetching): switch to fake timers, add 'vi.waitFor', and 'expect' test(svelte-query/useIsFetching): switch to fake timers, add 'expect', 'vi.waitFor', and replace 'findByText' with 'getByText' Jul 7, 2025
@sukvvon
test(svelte-query/useIsFetching): switch to fake timers, add 'expect'…
173687f 
…, 'vi.waitFor', and replace 'findByText' with 'getByText'
@sukvvon sukvvon force-pushed the test/svelte-query-useIsFetching-fake-timers-vi-waitFor branch from d8190c3 to 173687f Compare July 7, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: svelte-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sukvvon