fix(panel): fix title missing panel background #3718
Conversation
It looks like there's a history of issues related to the panel border style, so add a test to prevent any regressions.
Fix `Panel` title missing the panel background style. This really just reverts the change in 7a38204. There's a history of issues related to the panel title styles, so I was careful to run all the examples in those issues to ensure there wasn't any regression. Fixes Textualize#3569
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3718 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 74 74
Lines 8136 8151 +15
==========================================
+ Hits 7961 7975 +14
- Misses 175 176 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I suspect this one will come back to bite me. 🤷♂️ |
@willmcgugan I really hope not! I realise there's a history of issues related to this (see #3569 (comment)), so I was careful to run those examples to check there wasn't any regression, as well as the added tests. |
Fix
Paneltitle missing the panel background style.This really just reverts the change in 7a38204. There's a history of issues related to the panel title styles, so I was careful to run all the examples in those issues to ensure there wasn't any regression.
Fixes #3569
Type of changes
Checklist