Skip to content

fix(panel): fix title missing panel background #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TomJGooding
Copy link
Contributor

Fix Panel title missing the panel background style.

This really just reverts the change in 7a38204. There's a history of issues related to the panel title styles, so I was careful to run all the examples in those issues to ensure there wasn't any regression.

Fixes #3569

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

It looks like there's a history of issues related to the panel border
style, so add a test to prevent any regressions.
Fix `Panel` title missing the panel background style.

This really just reverts the change in 7a38204. There's a history of
issues related to the panel title styles, so I was careful to run all
the examples in those issues to ensure there wasn't any regression.

Fixes Textualize#3569
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (b96cd22) to head (6b8b3fa).
Report is 33 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3718      +/-   ##
==========================================
- Coverage   97.84%   97.84%   -0.01%     
==========================================
  Files          74       74              
  Lines        8136     8151      +15     
==========================================
+ Hits         7961     7975      +14     
- Misses        175      176       +1     
Flag Coverage Δ
unittests 97.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willmcgugan
Copy link
Member

I suspect this one will come back to bite me. 🤷‍♂️

@willmcgugan willmcgugan merged commit 21b3800 into Textualize:master Jun 24, 2025
20 checks passed
@TomJGooding
Copy link
Contributor Author

I suspect this one will come back to bite me. 🤷‍♂️

@willmcgugan I really hope not! I realise there's a history of issues related to this (see #3569 (comment)), so I was careful to run those examples to check there wasn't any regression, as well as the added tests.

@TomJGooding TomJGooding deleted the fix-panel-fix-title-missing-panel-background branch June 24, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]In the latest versions rich "Title" without color
3 participants