Remove typing-extensions as a runtime dependency
#3763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
remove-typing-extensions-runtime
branch
from
b1340e8 to
113bc1f
Compare
notatallshaw
force-pushed
the
remove-typing-extensions-runtime
branch
from
113bc1f to
3f5425e
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3763 +/- ##
==========================================
- Coverage 98.24% 97.97% -0.27%
==========================================
Files 74 74
Lines 8105 8118 +13
==========================================
- Hits 7963 7954 -9
- Misses 142 164 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
FWIW, I already filed a PR for this here and on pip's end: #3700 and pypa/pip#13336. |
|
🤦 forgot / missed this sorry. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3762
Type of changes
Checklist
Description
Remove
typing-extensionsas a runtime dependency by:sys.version_info >= (3, 8)blocks as rich no longer supports Python 3.7typing_extensionsimport into aTYPE_CHECKINGblocktyping-extensionsfrom a runtime dependency to a dev dependency in thepyproject.tomlfileI did have some problems running pre-commit locally, hopefully that was just a local issue, I will fix any CI issues if they come up.