-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Remove typing-extensions
as a runtime dependency
#3763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove typing-extensions
as a runtime dependency
#3763
Conversation
b1340e8
to
113bc1f
Compare
113bc1f
to
3f5425e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3763 +/- ##
==========================================
- Coverage 98.24% 97.97% -0.27%
==========================================
Files 74 74
Lines 8105 8118 +13
==========================================
- Hits 7963 7954 -9
- Misses 142 164 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FWIW, I already filed a PR for this here and on pip's end: #3700 and pypa/pip#13336. |
🤦 forgot / missed this sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3762
Type of changes
Checklist
Description
Remove
typing-extensions
as a runtime dependency by:sys.version_info >= (3, 8)
blocks as rich no longer supports Python 3.7typing_extensions
import into aTYPE_CHECKING
blocktyping-extensions
from a runtime dependency to a dev dependency in thepyproject.toml
fileI did have some problems running pre-commit locally, hopefully that was just a local issue, I will fix any CI issues if they come up.