Skip to content

permit nested live #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2025
Merged

permit nested live #3768

merged 7 commits into from
Jun 18, 2025

Conversation

willmcgugan
Copy link
Member

Allow nesting of Live instances.

Currently if you attempted to activate a Live when one was already running, then it would raise an error.

This update keeps a stack of Live objects on the console, and adds nested renderables to the top-most Live. The effect is that the nested Live appears below the first one(s). I suspect this is what most people will want.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.89%. Comparing base (45cc90b) to head (5a2db8f).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
rich/live.py 55.55% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3768      +/-   ##
==========================================
- Coverage   97.98%   97.89%   -0.10%     
==========================================
  Files          74       74              
  Lines        8142     8155      +13     
==========================================
+ Hits         7978     7983       +5     
- Misses        164      172       +8     
Flag Coverage Δ
unittests 97.89% <65.21%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willmcgugan willmcgugan merged commit 27d9230 into master Jun 18, 2025
21 checks passed
@willmcgugan willmcgugan deleted the nested-live branch June 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants