Skip to content

refactor: improve code and test coverage for MapReduce example #6348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 6, 2025

  • Renamed mapreduce method to countWordFrequencies for improved clarity and accuracy
  • Improved internal word splitting by using trim() and split("\\s+") for better whitespace handling
  • Replaced manual string building with Collectors.joining(",") for cleaner reduce phase logic
  • Added parameterized tests
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (350f149) to head (7f5900d).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6348      +/-   ##
============================================
- Coverage     74.56%   74.56%   -0.01%     
  Complexity     5451     5451              
============================================
  Files           682      682              
  Lines         19036    19032       -4     
  Branches       3690     3689       -1     
============================================
- Hits          14194    14191       -3     
  Misses         4277     4277              
+ Partials        565      564       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alxkm alxkm merged commit 4b6006c into TheAlgorithms:master Jul 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants