-
-
Notifications
You must be signed in to change notification settings - Fork 47k
Bytes to Int #6590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Bytes to Int #6590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95327be
to
ae03bbb
Compare
cclauss
reviewed
Oct 3, 2022
7fb30e2
to
c4e3f7b
Compare
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 3, 2022
Co-authored-by: Christian Clauss <[email protected]>
cclauss
requested changes
Oct 5, 2022
8189074
to
6a670ce
Compare
cclauss
reviewed
Oct 5, 2022
cclauss
reviewed
Oct 5, 2022
cclauss
reviewed
Oct 5, 2022
1567859
to
1805623
Compare
cclauss
reviewed
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
19e2e1e
to
cf76880
Compare
cclauss
reviewed
Oct 5, 2022
fae78bd
to
419fd26
Compare
cclauss
reviewed
Oct 5, 2022
f58fcf9
to
fded1a6
Compare
19527fb
to
bdebbde
Compare
for more information, see https://pre-commit.ci
Hi, I committed the change, can you please add a hacktoberfest label to the
commit?
…On Mon, Oct 3, 2022 at 3:24 PM Christian Clauss ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In conversions/bytes_to_int.py
<#6590 (comment)>:
> + if flag is True:
+ temp = str(temp) + "1"
+ else:
+ temp = str(temp) + "0"
⬇️ Suggested change
- if flag is True:
- temp = str(temp) + "1"
- else:
- temp = str(temp) + "0"
+ temp += str(int(flag))
—
Reply to this email directly, view it on GitHub
<#6590 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZAMR4GBU7OL6FGPRPTMQY3WBKUM7ANCNFSM6AAAAAAQ3JTJWQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.