Triangular number #896
Open
Triangular number #896
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 95.32% 95.52% +0.20%
==========================================
Files 319 320 +1
Lines 20807 23021 +2214
==========================================
+ Hits 19834 21991 +2157
- Misses 973 1030 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vil02
requested changes
Jul 6, 2025
Comment on lines
+1
to
+2
| // Triangular Numbers: Function to the Nth Triangular Number | ||
| // Wikipedia Reference : https://en.wikipedia.org/wiki/Triangular_number |
There was a problem hiding this comment.
Please explain what this module provides.
src/math/triangular_number.rs
Outdated
| // Triangular Numbers: Function to the Nth Triangular Number | ||
| // Wikipedia Reference : https://en.wikipedia.org/wiki/Triangular_number | ||
| use num_bigint::BigUint; | ||
| pub fn triangular_number(n: u64) -> BigUint { |
There was a problem hiding this comment.
BigUint seems to be an overkill here.
src/math/triangular_number.rs
Outdated
Comment on lines
5
to
6
| let m: BigUint = ((n | 1) * ((n + 1) / 2)).into(); | ||
| m |
There was a problem hiding this comment.
Why not:
Suggested change
| let m: BigUint = ((n | 1) * ((n + 1) / 2)).into(); | |
| m | |
| ((n | 1) * ((n + 1) / 2)).into() |
src/math/triangular_number.rs
Outdated
Comment on lines
26
to
28
| input_5: (6, BigUint::from(21u32)), | ||
| input_9: (10, BigUint::from(55u32)), | ||
| input_10: (100, BigUint::from(5050u32)), |
There was a problem hiding this comment.
What is the logic behind the names of the test cases?
Please add a text case with odd input and the first ones like:
input_0: (0, BigUint::from(0u32)),
input_1: (1, BigUint::from(1u32)),…or being overkill. Removed the use and returning of the variable m. Renamed the names of the test cases to something more logical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
A triangular number is a figurate number that counts objects arranged in an equilateral triangle. The standard formula for finding these can result in integer overflow due to the multiplication, so I added a OR binary operation to be able to find larger integers.
https://en.wikipedia.org/wiki/Triangular_number
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.