Improvements

.gitignore

@@ -45,4 +45,6 @@ testem.log
 Thumbs.db
 
 .nx/cache
-.nx/workspace-data
+.nx/workspace-data
+.cursor/rules/nx-rules.mdc
+.github/instructions/nx.instructions.md

package.json

@@ -33,8 +33,8 @@
   },
   "dependencies": {
     "@actions/core": "^1.11.1",
-    "@nx/devkit": "20.0.0",
-    "@nx/workspace": "20.0.0",
+    "@nx/devkit": "21.2.1",
+    "@nx/workspace": "21.2.1",
     "@types/tar": "^6.1.13",
     "axios": "^1.9.0",
     "crypto-js": "^4.2.0",
@@ -49,13 +49,13 @@
     "@google-cloud/storage": "^7.16.0",
     "@jamesives/github-pages-deploy-action": "^4.7.3",
     "@jscutlery/semver": "^5.6.0",
-    "@nx/eslint-plugin": "20.0.0",
-    "@nx/jest": "20.0.0",
-    "@nx/js": "20.0.0",
-    "@nx/node": "20.0.0",
-    "@nx/plugin": "20.0.0",
-    "@nx/react": "20.0.0",
-    "@nx/webpack": "20.0.0",
+    "@nx/eslint-plugin": "21.2.1",
+    "@nx/jest": "21.2.1",
+    "@nx/js": "21.2.1",
+    "@nx/node": "21.2.1",
+    "@nx/plugin": "21.2.1",
+    "@nx/react": "21.2.1",
+    "@nx/webpack": "21.2.1",
     "@pulumi/gcp": "^8.34.0",
     "@pulumi/pulumi": "^3.175.0",
     "@types/jest": "29.5.14",
@@ -69,11 +69,11 @@
     "eslint": "8.57.0",
     "eslint-config-prettier": "9.1.0",
     "eslint-plugin-simple-import-sort": "^12.1.1",
-    "express": "^4.21.1",
+    "express": "4.21.2",
     "husky": "^9.1.7",
     "jest": "29.7.0",
     "jest-environment-jsdom": "29.7.0",
-    "nx": "20.0.0",
+    "nx": "21.2.1",
     "prettier": "3.5.3",
     "ts-jest": "29.4.0",
     "ts-node": "10.9.2",

packages/e2e-runner/src/executors/run/run.impl.ts

@@ -49,6 +49,7 @@ export async function endToEndRunner(
       case 'playwright':
         logger.warn('Runner "playwright" is no longer maintained in favor of @nx/playwright!')
 
+        // TODO:: This is still being added to npm package.json
         // eslint-disable-next-line @typescript-eslint/no-var-requires,no-case-declarations
         const playwrightExecutor = require('@nx-extend/playwright/src/executors/test/test.impl').default
 

packages/gcp-cloud-run/src/executors/deploy/deploy.impl.ts

@@ -116,7 +116,7 @@ export async function deployExecutor(
     gcloudDeploy = 'gcloud beta run deploy'
   }
 
-  const deployCommand = buildCommand([
+  return execCommand(buildCommand([
     `${gcloudDeploy} ${name}`,
     `--project=${project}`,
     '--platform=managed',
@@ -145,9 +145,7 @@ export async function deployExecutor(
 
     // Add all sidecars
     ...sidecars.flatMap((sidecarOptions) => getContainerFlags(sidecarOptions, true)),
-  ])
-
-  return execCommand(deployCommand, {
+  ]), {
     cwd: distDirectory
   }, options.dryRun)
 }