Skip to content

Create slicing-error-check.yml #20694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2025
Merged

Create slicing-error-check.yml #20694

merged 6 commits into from
Jun 16, 2025

Conversation

HellAholic
Copy link
Contributor

Description

Workflow that is triggered when an issue is opened or edited, if the issue has the label slicing error, it checks to see if a .zip file has been attached.
If it does not contain a .zip file, it will post a message and add the label needs info automatically.

Type of change

  • New feature (non-breaking change which adds functionality)

@HellAholic HellAholic requested a review from Copilot June 15, 2025 14:30
Copilot

This comment was marked as outdated.

@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: Automation and build 🤖 Improving CI/CT/CD workflows labels Jun 15, 2025
@HellAholic HellAholic requested a review from Copilot June 15, 2025 17:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new GitHub Actions workflow to automatically verify that issues labeled or containing slicing errors include a .zip attachment, and flags those that don’t.

  • Introduces .github/workflows/slicing-error-check.yml
  • Triggers on issue opened/edited events
  • Checks issue body for .zip links, comments and labels issues missing the attachment
Comments suppressed due to low confidence (1)

.github/workflows/slicing-error-check.yml:48

  • Logging the echo command won’t write to the GITHUB_OUTPUT file, so the needs_info output will never be set. Instead, write directly to the output file (e.g., using fs.appendFileSync(process.env.GITHUB_OUTPUT, needs_info=${setNeedsInfoOutput}\n);) or use core.setOutput('needs_info', setNeedsInfoOutput) from @actions/core.
console.log(`echo "needs_info=${setNeedsInfoOutput.toString()}" >> $GITHUB_OUTPUT`);

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool addition 🙂 and looks good, just some suggestions

@wawanbreton wawanbreton merged commit 257e54c into main Jun 16, 2025
@wawanbreton wawanbreton deleted the slicing_error_check_workflow branch June 16, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Automation and build 🤖 Improving CI/CT/CD workflows PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants