-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Create slicing-error-check.yml #20694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new GitHub Actions workflow to automatically verify that issues labeled or containing slicing errors include a .zip
attachment, and flags those that don’t.
- Introduces
.github/workflows/slicing-error-check.yml
- Triggers on issue opened/edited events
- Checks issue body for
.zip
links, comments and labels issues missing the attachment
Comments suppressed due to low confidence (1)
.github/workflows/slicing-error-check.yml:48
- Logging the echo command won’t write to the GITHUB_OUTPUT file, so the
needs_info
output will never be set. Instead, write directly to the output file (e.g., usingfs.appendFileSync(process.env.GITHUB_OUTPUT,
needs_info=${setNeedsInfoOutput}\n);
) or usecore.setOutput('needs_info', setNeedsInfoOutput)
from@actions/core
.
console.log(`echo "needs_info=${setNeedsInfoOutput.toString()}" >> $GITHUB_OUTPUT`);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool addition 🙂 and looks good, just some suggestions
Description
Workflow that is triggered when an issue is opened or edited, if the issue has the label slicing error, it checks to see if a .zip file has been attached.
If it does not contain a .zip file, it will post a message and add the label needs info automatically.
Type of change