Skip to content

Update normal.inst.cfg #20712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

HellAholic
Copy link
Contributor

Quality does not have any values
The layer height defaults to 0.2 which makes it identical to other global quality profile for draft resources/quality/draft.inst.cfg

  • Bug fix (non-breaking change which fixes an issue)

HellAholic and others added 2 commits June 19, 2025 22:06
Quality does not have any values
The layer height defaults to 0.2 which makes it identical to other global quality profile for draft
resources/quality/draft.inst.cfg
@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor labels Jun 19, 2025
@HellAholic HellAholic requested a review from Frederic98 June 20, 2025 07:22
@wawanbreton
Copy link
Contributor

Hmm, it is a very small change but has a large impact ! This is the default quality, right ? Maybe the draft quality should be changed instead ? Just asking questions 😛

@HellAholic
Copy link
Contributor Author

Comparing the list of available quality files, the missing layer height is the 0.1 (which also lines up with the definition of fine in UM printers).
The draft/Fast is the 0.2mm layer height also based on the UM profiles.
So I think the 0.1 is the correct value that fits the gap as we do have 0.06, xx , 0.15, 0.2, 0.3, ..., 0.6

@wawanbreton
Copy link
Contributor

It seems consistent indeed... But that means all the "normal" profile that are now in 0.2 will change to 0.1, right ? This has a big impact as all the print times will be 2 times longer...

@HellAholic
Copy link
Contributor Author

I'll do an assessment of impact, so we can leave this open for now until we have the data.

@Frederic98
Copy link
Contributor

Hmm... These qualities are for fdmprinter.def.json. There, the default layer height is 0.1mm. So adding it shouldn't have any impact (?) 🤔

"default_value": 0.1,

@HellAholic
Copy link
Contributor Author

It has an impact for printers that don't have quality profiles, but need to check the diff between the 0.2 fine and 0.2 draft. Technically it's a bug that the fine was resolving to 0.2mm but better double check.

@HellAholic
Copy link
Contributor Author

From the data we have, there is a long list of printers that are affected with this change, however, when we take a look at per printer usage of the fine 0.2, there is only 8 printers that have sliced with that profile.
From that, the top printer with the most number of slices for Fine 0.2 only has 1.7% of slices done in that profile in the past year.
I think this should be included as a highlight during the release notes but the overall impact at the moment is pretty contained.

@wawanbreton
Copy link
Contributor

From the data we have, there is a long list of printers that are affected with this change, however, when we take a look at per printer usage of the fine 0.2, there is only 8 printers that have sliced with that profile. From that, the top printer with the most number of slices for Fine 0.2 only has 1.7% of slices done in that profile in the past year. I think this should be included as a highlight during the release notes but the overall impact at the moment is pretty contained.

Cool, thanks for checking ! Should we get an approval from @MariMakes, or maybe that was already discussed ?

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Test Results

23 953 tests  ±0   23 951 ✅ ±0   47s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit f1afb69. ± Comparison against base commit 4e04d06.

@HellAholic HellAholic merged commit 04acc9a into main Jul 7, 2025
4 checks passed
@HellAholic HellAholic deleted the Add-layer-height-to-fine-global-quality-for-fdm branch July 7, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants