Skip to content

Create find-packages.yml #20717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Create find-packages.yml #20717

merged 2 commits into from
Jun 20, 2025

Conversation

HellAholic
Copy link
Contributor

No description provided.

@HellAholic HellAholic requested a review from Copilot June 20, 2025 18:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow to discover Conan packages based on a Jira ticket tag.

  • Validates Jira ticket format
  • Searches all configured Conan remotes for matching packages
  • Summarizes findings in the GitHub Actions run summary
Comments suppressed due to low confidence (5)

.github/workflows/find-packages.yml:46

  • The flags for set are in the wrong order; use set -euo pipefail to correctly enable errexit, nounset, and pipefail.
          set -eou pipefail

.github/workflows/find-packages.yml:64

  • Using ..name may match nested name fields unintentionally; prefer .[] | .name to directly extract each top-level remote name.
          REMOTE_NAMES=$(echo "$REMOTES_JSON" | jq -r '..name')

.github/workflows/find-packages.yml:28

  • [nitpick] The placeholder # in cura_# may be ambiguous; consider using cura_<digits> in the error message for clarity.
            echo "::error::Invalid Jira ticket number format. Expected format: cura_# (e.g., cura_12345)."

.github/workflows/find-packages.yml:50

  • The version 5.11.0-alpha.0 is hardcoded; consider making it a workflow input or defining it as a top-level variable to simplify future updates.
          CONAN_PACKAGE_REFERENCE="5.11.0-alpha.0@ultimaker/${JIRA_TICKET}"

.github/workflows/find-packages.yml:38

  • [nitpick] Installing jq on every run can slow down the workflow; consider using an action that bundles jq, or caching the package to speed up builds.
        run: sudo apt-get update && sudo apt-get install -y jq

@HellAholic HellAholic merged commit 44ff265 into main Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant