[Strings] Add a string-builtins feature, and lift/lower automatically when enabled #7601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
May 16, 2025
Comment on lines
+432
to
+434
| PassRunner::Ordering ordering; | ||
| ordering.first = (i == firstDefault); | ||
| ordering.last = (i == lastDefault); |
There was a problem hiding this comment.
Alternatively:
Suggested change
| PassRunner::Ordering ordering; | |
| ordering.first = (i == firstDefault); | |
| ordering.last = (i == lastDefault); | |
| PassRunner::Ordering ordering{i == firstDefault, i == lastDefault}; |
|
|
||
| ;; RUN: foreach %s %t wasm-opt -O2 --enable-reference-types -S -o - | filecheck %s --check-prefix=MVP | ||
| ;; RUN: foreach %s %t wasm-opt -O2 -all -S -o - | filecheck %s --check-prefix=ALL | ||
| ;; RUN: foreach %s %t wasm-opt -O2 --enable-reference-types --enable-string-builtins -S -o - | filecheck %s --check-prefix=ESB |
There was a problem hiding this comment.
If you enable GC here, the printed output should be the same as with -all, so you could use one fewer check prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes string optimizations happen automatically when
--enable-string-builtins(or-all).The lifting/lowering happen globally, at optimal times in the
pipeline, so even
-O3 -O3 -O3will only lift once and lower once,avoiding overhead as in #7540 which this replaces.
TODO: document in optimizer cookbook