FED-3476 Adjust builder for Dart 3 #972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The over_react builder fails to generate code when there are analysis errors in the source file, regardless of their severity, due to the short-circuit here.
Historically, this hasn't been an issue since we do a non-resolved AST parse, and most infos/warnings require resolved AST.
However, apparently the warning for bad doc comment directives comes through in unresolved AST.
This causes failures to emit several over_react.g.dart files due to doc comments like this:
and also outputs this warning:
This issue should not prevent over_react from generating code.