Skip to content

Add otel instrumentation #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blakeroberts-wk
Copy link
Contributor

Motivation

During failure scenarios of establishing a websocket connection in deployed environments, it is difficult to understand the cause and effect of the failure. Likewise, it's difficult to understand the current health/distribution of transport types that SockJS uses.

Changes

OpenTelemetry instrumentation was added to capture the open and close events of SockJS as OpenTelemetry span events.

Additionally, a unit test for the recently added timeout option was added.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@blakeroberts-wk
Copy link
Contributor Author

QA +1 open span event appeared on the expected parent span when these changes were pulled into a test app:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant