Skip to content

Sniffer bug: fakedns alone should not override domain for tls/http/quic (when there is no map-domain) #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

patterniha
Copy link
Contributor

@patterniha patterniha commented May 16, 2025

currently, "destOverride": ["fakedns"] override domain for tls/http/quic protocol when ip is in fake-pool-range and when we have no map-domain.

This shouldn't happen and this is fakedns+others job.

///

also, it seems fakedns+others has no practical use and can be removed later.

@patterniha patterniha changed the title Sniffer bug: fakedns should not override domain for tls/http/quic when there is no map-domain. Sniffer bug: fakedns should not override domain for tls/http/quic (when there is no map-domain) May 16, 2025
@patterniha patterniha changed the title Sniffer bug: fakedns should not override domain for tls/http/quic (when there is no map-domain) Sniffer bug: fakedns alone should not override domain for tls/http/quic (when there is no map-domain) May 16, 2025
@yuhan6665
Copy link
Member

This is a feature I developed, not a bug. I had discussion with Fangliding.

@yuhan6665 yuhan6665 closed this May 16, 2025
@patterniha
Copy link
Contributor Author

patterniha commented May 17, 2025

This is a feature I developed, not a bug. I had discussion with Fangliding.

@yuhan6665 @Fangliding

  1. documentation says:
    其中 ["fakedns+others"] 相当于 ["http", "tls", "quic", "fakedns"]

But it is not equal to ["http", "tls", "quic", "fakedns"]

  1. Also, documentation says:
    当 IP 地址处于 FakeIP 区间内但没有命中域名记录时会使用 http、tls 和 quic 进行匹配。

But this is not correct: #4726 (comment), #4726 (comment)

///

The documentation says two contradictory things, neither of which is correct !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants