Skip to content

Mainnet Parsing Fixes #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 2, 2025
Merged

Mainnet Parsing Fixes #403

merged 13 commits into from
Jun 2, 2025

Conversation

ziscky
Copy link
Contributor

@ziscky ziscky commented May 30, 2025

  • refactor multisig to not use rosetta for multisig param parsing and cover all versions
  • add fallback parsing to market,miner and reward actor methods with unexpected messages at some heights
  • call StateGetActor with a tipset key first, before retrying with an EmptyTSK

🔗 zboto Link

Copy link

windsurf-bot bot commented May 30, 2025

I ran into an unexpected issue while reviewing this PR. Please try again later.

Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have issues with linting, but once fix, we can merge. I know we have done more indexing since this PR was created. Let's check there is no new cases to fix before merging!

@emmanuelm41 emmanuelm41 merged commit 785a150 into dev Jun 2, 2025
6 checks passed
@emmanuelm41 emmanuelm41 deleted the fix/multisig branch June 2, 2025 12:10
emmanuelm41 added a commit that referenced this pull request Jun 2, 2025
* fix: call StateGetActor with tipset first

* feat: blockCid error reporting

* feat: fix miner methods and add fallback

* feat: market add return fallback

* feat: reward add  fallback

* feat: refactor multisig actor

* test: fix tests

* chore: go mod tidy

* fix: reward constructor

* fix: lint

* feat: add reward comments

* fix: tests

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants