Skip to content

code optimization #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

code optimization #2032

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc3e99b
optimization
yilianhuaixiao Oct 29, 2019
f4ca204
optimization
yilianhuaixiao Oct 29, 2019
d49966b
Merge branch 'dev' of https://github.com/abpframework/abp
yilianhuaixiao Oct 29, 2019
690940f
optimization
yilianhuaixiao Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimization
  • Loading branch information
@yilianhuaixiao
yilianhuaixiao committed Oct 29, 2019
commit f4ca2046923f116f5db7beecd708f67dc203e980
4 changes: 2 additions & 2 deletions ...lo.Abp.Core/Microsoft/Extensions/DependencyInjection/ServiceCollectionCommonExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public static IServiceProvider BuildServiceProviderFromFactory([NotNull] this IS
foreach (var service in services)
{
var factoryInterface = service.ServiceType;
if (service.ServiceType==null || !service.ServiceType.IsGenericType ||
service.ServiceType.GetTypeInfo().GetGenericTypeDefinition() != typeof(IServiceProviderFactory<>))
if (factoryInterface==null || !factoryInterface.IsGenericType ||
factoryInterface.GetTypeInfo().GetGenericTypeDefinition() != typeof(IServiceProviderFactory<>))
{
continue;
}
Expand Down