Add other ui options for microservice tutorial #22730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 17.3%, saving 236.20 KB.
2912 images did not require optimisation. |
|
Maybe it could be better to adding this changes to the 9.1 patch as well. |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 11.9%, saving 283.45 KB.
2925 images did not require optimisation. |
|
@m-aliozkaya I selected different UI's but sample project link doesn't change. We can create sample projects for;
For other options, we can hide the sample download link.
|
|
|
ismcagdas
requested changes
May 12, 2025
There was a problem hiding this comment.
I have tested Angular version and completed my review, here are my comments;
#22730 (comment)
#22730 (comment)
#22730 (comment)
Overally, angular document is very good 🙏
gizemmutukurt
requested changes
May 22, 2025
There was a problem hiding this comment.
-
In the Blazor Server training, a Web project screenshot appears to have been added to the module settings.
-
After creating the Entities folder where we added the code from the document, it would be useful to clearly state that we will create a file named Order.cs and write this code into it.
|
|
gizemmutukurt
requested changes
May 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Microservice Tutorial documentation to support additional UI options and database providers, expanding configuration variability for users.
- Introduces a new doc-params JSON block in each tutorial part to clearly define available UI and DB options.
- Adds conditional logic to display UI-specific instructions and images for MVC, Blazor, Angular, etc.
- Updates several tutorial sections to reflect new integration steps for these options.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/en/tutorials/microservice/part-07.md | Added doc-params block for UI and DB along with minor formatting changes. |
| docs/en/tutorials/microservice/part-06.md | Updated UI sections with conditional blocks for different frameworks and clarified proxy generation instructions. |
| docs/en/tutorials/microservice/part-05.md | Revised instructions for creating the Order entity and added UI-specific sections for Blazor; introduced Angular order component snippet. |
| docs/en/tutorials/microservice/part-04.md | Added doc-params block and UI/DB conditional code for improved step clarity. |
| docs/en/tutorials/microservice/part-03.md | Updated UI conditionals and image references for multiple frameworks. |
| docs/en/tutorials/microservice/part-02.md | Introduced doc-params block and conditional integration instructions. |
| docs/en/tutorials/microservice/part-01.md | Reorganized initial configuration instructions using conditionals for DB and UI framework options. |
| docs/en/tutorials/microservice/index.md | Added the new doc-params block for consistency across tutorials. |
| selector: 'lib-order', | ||
| standalone: false, | ||
| templateUrl: './order.component.html', | ||
| styleUrl: './order.component.css' |
There was a problem hiding this comment.
In Angular, the component decorator property should be 'styleUrls' (an array) instead of 'styleUrl'. Please update this to ensure the styles are correctly applied.
Suggested change
| styleUrl: './order.component.css' | |
| styleUrls: ['./order.component.css'] |
Copilot uses AI. Check for mistakes.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related https://github.com/volosoft/vs-internal/issues/5566