Skip to content

Remove arg count or #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove arg count or #17

wants to merge 4 commits into from

Conversation

Nilos
Copy link
Collaborator

@Nilos Nilos commented Mar 2, 2015

No description provided.

@Nilos
Copy link
Collaborator Author

Nilos commented Mar 2, 2015

I am pretty sure that we could also cache messageNotUnderstood's. Adding that now!

@Nilos
Copy link
Collaborator Author

Nilos commented Mar 2, 2015

@hotzenklotz @abstraktor Please review!

@abstraktor
Copy link
Owner

@Nilos No, I don't think that's working as the cache invalidation doesn't work properly anymore:

  • Let's say Car inherits Vehicle.
  • Sending Car>>goHome will not be found, so Object>>messageNotUnderstood: will be run
  • Adding Vehicle>>messageNotUnderstood will not be noticed by the guard and Calling Car>>goHome will call Object>>messageNotUnderstood instead of Vehicle>>messageNotUnderstood
  • we would need to invalidate them with each other, changing goHome will invalidate the inline cache for messageNotUnderstood: and vice versa…

@Nilos
Copy link
Collaborator Author

Nilos commented Mar 9, 2015

We need to merge the fix for primitive 233!

@abstraktor
Copy link
Owner

(I merged 896a535 so that we can still discuss that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nilos @abstraktor @codefrau