Skip to content

fix: typo in BrokenWorkerIntepreter #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 11, 2025

Conversation

ayussh-verma
Copy link
Contributor

@ayussh-verma ayussh-verma commented Jul 3, 2025

Changes

Renames BrokenWorkerIntepreter to BrokenWorkerInterpreter;

Checklist

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

@agronholm
Copy link
Owner

Please also add a test for the import, using with pytest.warns(DeprecationWarning, ...):

@ayussh-verma
Copy link
Contributor Author

Thanks, made the changes

@ayussh-verma ayussh-verma marked this pull request as draft July 8, 2025 11:58
@agronholm
Copy link
Owner

agronholm commented Jul 8, 2025

This is still marked as draft. I assume you want this merged now?

@ayussh-verma
Copy link
Contributor Author

Just waiting for the CI/CD to pass, it failed randomly last time

@ayussh-verma
Copy link
Contributor Author

Albeit the timeout looked unrelated

@ayussh-verma
Copy link
Contributor Author

I don't think the failures are related, pulling this out of draft

@ayussh-verma ayussh-verma marked this pull request as ready for review July 8, 2025 12:16
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agronholm agronholm merged commit 65fe287 into agronholm:master Jul 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants