Skip to content

Build armv7l manylinux wheels #10797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

Build armv7l manylinux wheels #10797

merged 2 commits into from
May 3, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 25, 2025

What do these changes do?

related issue #10794

Older versions of cibuildwheel used manylinux images that were missing some tooling needed to do builds. 2.23.0 switched images so that is no longer an issue as we have already updated yarl and multidict to produce manylinux armv7l builds. Note that propcache still has the exclude so that likely needs to be removed as well.

Are there changes in behavior for the user?

armv7l manylinux wheels

Is it a substantial burden for the maintainers to support this?

no

related issue #10794

Older versions of cibuildwheel used manylinux images
that were missing some tooling needed to do builds.
2.23.0 switched images so that is no longer an issue.
@bdraco bdraco requested a review from webknjaz as a code owner April 25, 2025 19:38
@bdraco bdraco requested a review from asvetlov as a code owner April 25, 2025 19:39
@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Apr 25, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 25, 2025
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (46b557a) to head (e804e7d).
Report is 13 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10797   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         125      125           
  Lines       37858    37858           
  Branches     2091     2091           
=======================================
  Hits        37375    37375           
  Misses        335      335           
  Partials      148      148           
Flag Coverage Δ
CI-GHA 98.60% <ø> (ø)
OS-Linux 98.27% <ø> (ø)
OS-Windows 96.21% <ø> (ø)
OS-macOS 97.39% <ø> (ø)
Py-3.10.11 97.31% <ø> (-0.02%) ⬇️
Py-3.10.17 97.84% <ø> (ø)
Py-3.11.12 97.91% <ø> (-0.01%) ⬇️
Py-3.11.9 97.40% <ø> (+<0.01%) ⬆️
Py-3.12.10 98.37% <ø> (-0.01%) ⬇️
Py-3.13.3 98.36% <ø> (-0.01%) ⬇️
Py-3.9.13 97.18% <ø> (-0.01%) ⬇️
Py-3.9.22 97.70% <ø> (-0.01%) ⬇️
Py-pypy7.3.16 92.62% <ø> (-4.65%) ⬇️
VM-macos 97.39% <ø> (ø)
VM-ubuntu 98.27% <ø> (ø)
VM-windows 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #10797 will not alter performance

Comparing armv7l_manylinux (e804e7d) with master (46b557a)

Summary

✅ 58 untouched benchmarks

@bdraco bdraco merged commit ceed502 into master May 3, 2025
43 checks passed
@bdraco bdraco deleted the armv7l_manylinux branch May 3, 2025 23:27
Copy link
Contributor

patchback bot commented May 3, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/ceed50286a123799d7ac9c494280375518c5f7cf/pr-10797

Backported as #10826

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 3, 2025
Copy link
Contributor

patchback bot commented May 3, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/ceed50286a123799d7ac9c494280375518c5f7cf/pr-10797

Backported as #10827

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 3, 2025
bdraco added a commit that referenced this pull request May 3, 2025
bdraco added a commit that referenced this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant