-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove constraint that prevented aiodns from being installed on Windows #10823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using pycares 4.7.0 or later closes #8121
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10823 +/- ##
==========================================
+ Coverage 97.41% 98.70% +1.28%
==========================================
Files 123 125 +2
Lines 37790 37858 +68
Branches 2080 2091 +11
==========================================
+ Hits 36814 37366 +552
+ Misses 804 343 -461
+ Partials 172 149 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10823 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit.
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10825 🤖 @patchback |
…aiodns from being installed on Windows (#10825) Co-authored-by: J. Nick Koston <[email protected]> closes #8121
Remove constraint that prevented aiodns from being installed on Windows
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using pycares 4.7.0 or later
Are there changes in behavior for the user?
aiodns is now available on windows
Is it a substantial burden for the maintainers to support this?
no
Related issue number
closes #8121
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.