Skip to content

Remove constraint that prevented aiodns from being installed on Windows #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 2, 2025

Remove constraint that prevented aiodns from being installed on Windows
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using pycares 4.7.0 or later

Are there changes in behavior for the user?

aiodns is now available on windows

Is it a substantial burden for the maintainers to support this?

no

Related issue number

closes #8121

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

As of aiodns 3.3.0 SelectorEventLoop is no longer required when using
pycares 4.7.0 or later

closes #8121
@bdraco bdraco added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label May 2, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 2, 2025
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (9dc0a06) to head (800e6ff).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10823      +/-   ##
==========================================
+ Coverage   97.41%   98.70%   +1.28%     
==========================================
  Files         123      125       +2     
  Lines       37790    37858      +68     
  Branches     2080     2091      +11     
==========================================
+ Hits        36814    37366     +552     
+ Misses        804      343     -461     
+ Partials      172      149      -23     
Flag Coverage Δ
CI-GHA 98.58% <ø> (+1.24%) ⬆️
OS-Linux 98.27% <ø> (?)
OS-Windows 96.40% <ø> (?)
OS-macOS 97.39% <ø> (+0.06%) ⬆️
Py-3.10.11 97.29% <ø> (+0.30%) ⬆️
Py-3.10.17 97.79% <ø> (?)
Py-3.11.12 97.92% <ø> (?)
Py-3.11.9 97.37% <ø> (?)
Py-3.12.10 98.35% <ø> (+1.17%) ⬆️
Py-3.13.3 98.33% <ø> (+1.15%) ⬆️
Py-3.9.13 97.16% <ø> (?)
Py-3.9.22 97.70% <ø> (?)
Py-pypy7.3.16 92.76% <ø> (?)
VM-macos 97.39% <ø> (+0.06%) ⬆️
VM-ubuntu 98.27% <ø> (?)
VM-windows 96.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 2, 2025

CodSpeed Performance Report

Merging #10823 will not alter performance

Comparing aiodns_windows (800e6ff) with master (5c8526b)

Summary

✅ 58 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review May 2, 2025 20:11
@bdraco bdraco requested review from webknjaz and asvetlov as code owners May 2, 2025 20:11
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@webknjaz webknjaz enabled auto-merge (squash) May 3, 2025 17:59
@webknjaz webknjaz merged commit d17f2a4 into master May 3, 2025
40 checks passed
@webknjaz webknjaz deleted the aiodns_windows branch May 3, 2025 17:59
Copy link
Contributor

patchback bot commented May 3, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/d17f2a4cfb4fedc8cc9bede160a41a46b7a9e45d/pr-10823

Backported as #10825

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 3, 2025
…10823)

Remove constraint that prevented aiodns from being installed on Windows
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using
pycares 4.7.0 or later

(cherry picked from commit d17f2a4)
bdraco added a commit that referenced this pull request May 3, 2025
…aiodns from being installed on Windows (#10825)

Co-authored-by: J. Nick Koston <[email protected]>
closes #8121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiodns can probably be enabled on windows, now that it ships with c-ares already built
2 participants