Skip to content

[PR #10881/4facc402 backport][3.12] Remove License from setup.cfg #10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 19, 2025

This is a backport of PR #10881 as merged into master (4facc40).

What do these changes do?

From PEP-639 https://peps.python.org/pep-0639/
We need to have standard license descriptions

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Co-authored-by: J. Nick Koston <[email protected]>
(cherry picked from commit 4facc40)
@patchback patchback bot requested review from webknjaz and asvetlov as code owners May 19, 2025 16:09
@patchback patchback bot mentioned this pull request May 19, 2025
5 tasks
@bdraco bdraco enabled auto-merge (squash) May 19, 2025 16:13
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #10883 will not alter performance

Comparing patchback/backports/3.12/4facc4027f5a6a114d7650633a6c893323f3d1eb/pr-10881 (25f21a1) with 3.12 (6473180)

Summary

✅ 60 untouched benchmarks

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (6473180) to head (25f21a1).
Report is 2 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10883   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         128      128           
  Lines       38685    38685           
  Branches     2177     2177           
=======================================
  Hits        37964    37964           
  Misses        551      551           
  Partials      170      170           
Flag Coverage Δ
CI-GHA 98.02% <ø> (ø)
OS-Linux 97.75% <ø> (ø)
OS-Windows 95.19% <ø> (-0.01%) ⬇️
OS-macOS 96.90% <ø> (ø)
Py-3.10.11 96.78% <ø> (-0.01%) ⬇️
Py-3.10.17 97.34% <ø> (ø)
Py-3.11.12 97.44% <ø> (+0.03%) ⬆️
Py-3.11.9 96.88% <ø> (+<0.01%) ⬆️
Py-3.12.10 97.81% <ø> (ø)
Py-3.13.3 97.80% <ø> (ø)
Py-3.9.13 96.67% <ø> (ø)
Py-3.9.22 97.21% <ø> (+0.02%) ⬆️
Py-pypy7.3.16 89.32% <ø> (+4.81%) ⬆️
VM-macos 96.90% <ø> (ø)
VM-ubuntu 97.75% <ø> (ø)
VM-windows 95.19% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco closed this May 19, 2025
auto-merge was automatically disabled May 19, 2025 16:30

Pull request was closed

@bdraco bdraco reopened this May 19, 2025
@bdraco bdraco merged commit 1cfe028 into 3.12 May 19, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/4facc4027f5a6a114d7650633a6c893323f3d1eb/pr-10881 branch May 19, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants