Skip to content

[PR #10884/d758b7ae backport][3.12] Fix flakey middleware connection reuse test #10887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 19, 2025

This is a backport of PR #10884 as merged into master (d758b7a).

This test needs to explicitly release the response so the connection can get released to avoid the race.

Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #10887 will improve performances by 20.69%

Comparing patchback/backports/3.12/d758b7aefb2a418af2a1d3f6d271405ace0d6c14/pr-10884 (4487d23) with 3.12 (5044d53)

Summary

⚡ 13 improvements
✅ 47 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop] 4 ms 3.5 ms +11.9%
test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop] 297.3 ms 246.3 ms +20.69%
test_resolve_dynamic_resource_url_with_many_static_routes[pyloop] 4 ms 3.6 ms +12.42%
test_resolve_gitapi[pyloop] 343.1 ms 294.3 ms +16.59%
test_resolve_gitapi_root[pyloop] 2.4 ms 2 ms +20.64%
test_resolve_gitapi_subapps[pyloop] 344.1 ms 295 ms +16.66%
test_resolve_multiple_fixed_url_with_many_routes[pyloop] 2.6 ms 2.2 ms +18.83%
test_resolve_multiple_level_fixed_url_with_many_routes[pyloop] 10.2 ms 8.5 ms +19.08%
test_resolve_prefix_resources_many_prefix_many_plain[pyloop] 5.6 ms 4.9 ms +13.7%
test_resolve_root_route[pyloop] 1,041.6 µs 877.1 µs +18.76%
test_resolve_root_route_with_many_fixed_routes[pyloop] 1,045.4 µs 877.7 µs +19.11%
test_resolve_single_fixed_url_with_many_routes[pyloop] 1,044.8 µs 883 µs +18.33%
test_resolve_static_root_route[pyloop] 1,141.6 µs 975.5 µs +17.03%

@bdraco bdraco enabled auto-merge (squash) May 19, 2025 17:12
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (5044d53) to head (4487d23).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10887   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         128      128           
  Lines       38684    38685    +1     
  Branches     2177     2177           
=======================================
+ Hits        37963    37964    +1     
  Misses        551      551           
  Partials      170      170           
Flag Coverage Δ
CI-GHA 98.02% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.75% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.20% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.90% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.78% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.30% <100.00%> (-0.04%) ⬇️
Py-3.11.12 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.88% <100.00%> (-0.01%) ⬇️
Py-3.12.10 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.67% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.21% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.16 83.35% <100.00%> (-4.15%) ⬇️
VM-macos 96.90% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.75% <100.00%> (+<0.01%) ⬆️
VM-windows 95.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 6473180 into 3.12 May 19, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/d758b7aefb2a418af2a1d3f6d271405ace0d6c14/pr-10884 branch May 19, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant