Skip to content

Fix some unclosed socket warnings when tests fail #10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner May 19, 2025 17:15
@Dreamsorcerer Dreamsorcerer added backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note labels May 19, 2025
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (3c9d7ab) to head (86d05d1).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10888      +/-   ##
==========================================
- Coverage   98.74%   98.74%   -0.01%     
==========================================
  Files         127      127              
  Lines       38524    38483      -41     
  Branches     2123     2123              
==========================================
- Hits        38040    37999      -41     
  Misses        336      336              
  Partials      148      148              
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (-0.01%) ⬇️
OS-Linux 98.32% <100.00%> (-0.01%) ⬇️
OS-Windows 96.48% <100.00%> (-0.01%) ⬇️
OS-macOS 97.46% <100.00%> (-0.02%) ⬇️
Py-3.10.11 97.35% <99.55%> (-0.01%) ⬇️
Py-3.10.17 97.90% <99.55%> (+<0.01%) ⬆️
Py-3.11.12 97.98% <99.55%> (-0.01%) ⬇️
Py-3.11.9 97.43% <99.55%> (-0.01%) ⬇️
Py-3.12.10 98.39% <99.55%> (-0.01%) ⬇️
Py-3.13.3 98.38% <99.55%> (-0.01%) ⬇️
Py-3.9.13 97.22% <100.00%> (-0.01%) ⬇️
Py-3.9.22 97.76% <100.00%> (-0.02%) ⬇️
Py-pypy7.3.16 93.97% <100.00%> (-3.36%) ⬇️
VM-macos 97.46% <100.00%> (-0.02%) ⬇️
VM-ubuntu 98.32% <100.00%> (-0.01%) ⬇️
VM-windows 96.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #10888 will not alter performance

Comparing fix-unclosed-sockets (86d05d1) with master (d758b7a)

Summary

✅ 60 untouched benchmarks

@Dreamsorcerer Dreamsorcerer merged commit 918c76d into master May 19, 2025
40 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-unclosed-sockets branch May 19, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants