Skip to content

[PR #10891/802152a backport][3.12] Fix flakey signal handling tests #10896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2025

(cherry picked from commit 802152a)

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label May 20, 2025
@bdraco bdraco changed the title Fix flakey signal handling tests (#10891) [PR #10891/802152a backport][3.12] Fix flakey signal handling tests May 20, 2025
Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10896 will not alter performance

Comparing patchback/backports/3.12/802152af61bb29157724947dd0bd884e5394db71/pr-10891 (e6925b8) with 3.12 (ad7ee7c)

Summary

✅ 60 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review May 20, 2025 15:04
@bdraco bdraco requested a review from asvetlov as a code owner May 20, 2025 15:04
@bdraco bdraco enabled auto-merge (squash) May 20, 2025 15:04
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (ad7ee7c) to head (e6925b8).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10896      +/-   ##
==========================================
+ Coverage   98.13%   98.15%   +0.01%     
==========================================
  Files         130      130              
  Lines       39129    39137       +8     
  Branches     2218     2218              
==========================================
+ Hits        38401    38416      +15     
+ Misses        555      551       -4     
+ Partials      173      170       -3     
Flag Coverage Δ
CI-GHA 98.04% <100.00%> (+0.01%) ⬆️
OS-Linux 97.77% <100.00%> (+0.01%) ⬆️
OS-Windows 95.23% <0.00%> (+0.49%) ⬆️
OS-macOS 96.95% <100.00%> (+0.06%) ⬆️
Py-3.10.11 96.82% <100.00%> (+0.26%) ⬆️
Py-3.10.17 97.37% <100.00%> (+0.63%) ⬆️
Py-3.11.12 97.43% <100.00%> (+0.59%) ⬆️
Py-3.11.9 96.92% <100.00%> (+0.26%) ⬆️
Py-3.12.10 97.84% <100.00%> (+1.08%) ⬆️
Py-3.13.3 97.82% <100.00%> (+0.24%) ⬆️
Py-3.9.13 96.71% <100.00%> (+1.96%) ⬆️
Py-3.9.22 97.22% <100.00%> (+0.17%) ⬆️
Py-pypy7.3.16 86.54% <0.00%> (?)
VM-macos 96.95% <100.00%> (+0.06%) ⬆️
VM-ubuntu 97.77% <100.00%> (+0.01%) ⬆️
VM-windows 95.23% <0.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit d4eaf55 into 3.12 May 20, 2025
64 of 94 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/802152af61bb29157724947dd0bd884e5394db71/pr-10891 branch May 20, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant