Skip to content

[PR #10898/a4be2cb backport][3.12] Cleanup tests to ensure connector cleanup and resource management #10900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2025

(cherry picked from commit a4be2cb)

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label May 20, 2025
@bdraco bdraco changed the title Cleanup tests to ensure connector cleanup and resource management (#10898) [PR #10898/a4be2cb backport][3.12] Cleanup tests to ensure connector cleanup and resource management May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (d4eaf55) to head (7939238).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10900      +/-   ##
==========================================
+ Coverage   98.13%   98.15%   +0.01%     
==========================================
  Files         130      130              
  Lines       39137    39144       +7     
  Branches     2218     2218              
==========================================
+ Hits        38409    38423      +14     
+ Misses        555      551       -4     
+ Partials      173      170       -3     
Flag Coverage Δ
CI-GHA 98.04% <100.00%> (+0.01%) ⬆️
OS-Linux 97.77% <100.00%> (+0.01%) ⬆️
OS-Windows 95.23% <86.44%> (+<0.01%) ⬆️
OS-macOS 96.94% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.82% <100.00%> (-0.01%) ⬇️
Py-3.10.17 97.37% <100.00%> (+0.04%) ⬆️
Py-3.11.12 97.47% <100.00%> (+0.01%) ⬆️
Py-3.11.9 96.92% <100.00%> (+0.27%) ⬆️
Py-3.12.10 97.84% <100.00%> (+0.88%) ⬆️
Py-3.13.3 97.83% <100.00%> (+0.04%) ⬆️
Py-3.9.13 96.71% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.24% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 89.07% <86.44%> (?)
VM-macos 96.94% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.77% <100.00%> (+0.01%) ⬆️
VM-windows 95.23% <86.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10900 will degrade performances by 15.91%

Comparing patchback/backports/3.12/a4be2cba71e42aaa5a654760c86f860be2dfaa77/pr-10898 (7939238) with 3.12 (d4eaf55)

Summary

❌ 13 (👁 13) regressions
✅ 47 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop] 3.5 ms 3.9 ms -9.67%
👁 test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop] 247.3 ms 294 ms -15.91%
👁 test_resolve_dynamic_resource_url_with_many_static_routes[pyloop] 3.6 ms 4 ms -9.79%
👁 test_resolve_gitapi[pyloop] 294.2 ms 337.4 ms -12.8%
👁 test_resolve_gitapi_root[pyloop] 2 ms 2.4 ms -15.24%
👁 test_resolve_gitapi_subapps[pyloop] 296.4 ms 339.7 ms -12.73%
👁 test_resolve_multiple_fixed_url_with_many_routes[pyloop] 2.2 ms 2.6 ms -14.78%
👁 test_resolve_multiple_level_fixed_url_with_many_routes[pyloop] 8.5 ms 10.1 ms -15.08%
👁 test_resolve_prefix_resources_many_prefix_many_plain[pyloop] 4.9 ms 5.4 ms -10.38%
👁 test_resolve_root_route[pyloop] 880.4 µs 1,027.1 µs -14.28%
👁 test_resolve_root_route_with_many_fixed_routes[pyloop] 882.6 µs 1,028.5 µs -14.19%
👁 test_resolve_single_fixed_url_with_many_routes[pyloop] 891 µs 1,044.6 µs -14.7%
👁 test_resolve_static_root_route[pyloop] 979 µs 1,129.4 µs -13.32%

@bdraco bdraco closed this May 20, 2025
@bdraco bdraco reopened this May 20, 2025
@bdraco bdraco marked this pull request as ready for review May 20, 2025 17:52
@bdraco bdraco requested a review from asvetlov as a code owner May 20, 2025 17:52
@bdraco bdraco enabled auto-merge (squash) May 20, 2025 17:52
@bdraco bdraco merged commit c8c3d5f into 3.12 May 20, 2025
60 of 95 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/a4be2cba71e42aaa5a654760c86f860be2dfaa77/pr-10898 branch May 20, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant