Skip to content

Middleware cleanups #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 20, 2025
Merged

Middleware cleanups #10902

merged 20 commits into from
May 20, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2025

This is a followup to #9732 to do some small cleanups

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (a4be2cb) to head (cd9c2b7).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10902      +/-   ##
==========================================
- Coverage   98.75%   98.75%   -0.01%     
==========================================
  Files         129      129              
  Lines       38938    38951      +13     
  Branches     2164     2161       -3     
==========================================
+ Hits        38454    38465      +11     
- Misses        336      337       +1     
- Partials      148      149       +1     
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (-0.01%) ⬇️
OS-Linux 98.34% <100.00%> (-0.01%) ⬇️
OS-Windows 96.50% <100.00%> (-0.01%) ⬇️
OS-macOS 97.48% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.38% <100.00%> (-0.01%) ⬇️
Py-3.10.17 97.91% <100.00%> (-0.01%) ⬇️
Py-3.11.12 97.99% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.47% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 98.41% <100.00%> (-0.02%) ⬇️
Py-3.13.3 98.40% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.25% <100.00%> (-0.01%) ⬇️
Py-3.9.22 97.74% <100.00%> (-0.04%) ⬇️
Py-pypy7.3.16 88.30% <100.00%> (-0.89%) ⬇️
VM-macos 97.48% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.34% <100.00%> (-0.01%) ⬇️
VM-windows 96.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10902 will not alter performance

Comparing middleware_cleanup (cd9c2b7) with master (a4be2cb)

Summary

✅ 60 untouched benchmarks

@bdraco bdraco added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label May 20, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 20, 2025
@bdraco bdraco marked this pull request as ready for review May 20, 2025 19:33
@bdraco bdraco requested review from webknjaz and asvetlov as code owners May 20, 2025 19:33
@bdraco
Copy link
Member Author

bdraco commented May 20, 2025

#9732 (comment) remains an open discussion item. I will address in a future PR if we need to change it.

@bdraco bdraco merged commit 94de3f9 into master May 20, 2025
40 checks passed
@bdraco bdraco deleted the middleware_cleanup branch May 20, 2025 20:06
Copy link
Contributor

patchback bot commented May 20, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/94de3f9d3785660c5c40aa2c927bbaa48cf1bb33/pr-10902

Backported as #10904

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 20, 2025
(cherry picked from commit 94de3f9)
bdraco added a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant