-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Middleware cleanups #10902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middleware cleanups #10902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10902 +/- ##
==========================================
- Coverage 98.75% 98.75% -0.01%
==========================================
Files 129 129
Lines 38938 38951 +13
Branches 2164 2161 -3
==========================================
+ Hits 38454 38465 +11
- Misses 336 337 +1
- Partials 148 149 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10902 will not alter performanceComparing Summary
|
#9732 (comment) remains an open discussion item. I will address in a future PR if we need to change it. |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10904 🤖 @patchback |
(cherry picked from commit 94de3f9)
Co-authored-by: J. Nick Koston <[email protected]>
This is a followup to #9732 to do some small cleanups