Skip to content

[PR #10897/4624fed backport][3.12] Fix DNS resolver object churn for multiple sessions #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2025

(cherry picked from commit 4624fed)

@bdraco bdraco requested review from webknjaz and asvetlov as code owners May 20, 2025 20:15
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 20, 2025
@bdraco bdraco changed the title Fix DNS resolver object churn for multiple sessions (#10897) [PR #10897/4624fed backport][3.12] Fix DNS resolver object churn for multiple sessions May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (c8c3d5f) to head (82da571).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##             3.12   #10906    +/-   ##
========================================
  Coverage   98.15%   98.16%            
========================================
  Files         130      130            
  Lines       39144    39282   +138     
  Branches     2218     2223     +5     
========================================
+ Hits        38423    38561   +138     
  Misses        551      551            
  Partials      170      170            
Flag Coverage Δ
CI-GHA 98.05% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.78% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.25% <100.00%> (+0.01%) ⬆️
OS-macOS 96.96% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.84% <100.00%> (+0.01%) ⬆️
Py-3.10.17 97.38% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.93% <100.00%> (+0.01%) ⬆️
Py-3.12.10 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.72% <100.00%> (+0.01%) ⬆️
Py-3.9.22 97.26% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 85.42% <100.00%> (-2.58%) ⬇️
VM-macos 96.96% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.78% <100.00%> (+<0.01%) ⬆️
VM-windows 95.25% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10906 will not alter performance

Comparing patchback/backports/3.12/4624fed82608d9b659c4284814a570e0b332b8db/pr-10897 (82da571) with 3.12 (c8c3d5f)

Summary

✅ 60 untouched benchmarks

@bdraco bdraco enabled auto-merge (squash) May 20, 2025 20:29
@bdraco bdraco merged commit 64fc600 into 3.12 May 20, 2025
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/4624fed82608d9b659c4284814a570e0b332b8db/pr-10897 branch May 20, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant