Skip to content

Mark the removal of make_mocked_coro as a breaking change #10913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2025

Adds a symlink for the change note in #10910 to also mark it breaking.

The backports done to 3.11 will be partial to leave the function in but we will remove all usage in our tests.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (36a2567) to head (5803134).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10913      +/-   ##
==========================================
- Coverage   98.75%   98.74%   -0.01%     
==========================================
  Files         129      129              
  Lines       39072    39072              
  Branches     2164     2164              
==========================================
- Hits        38586    38583       -3     
- Misses        337      340       +3     
  Partials      149      149              
Flag Coverage Δ
CI-GHA 98.63% <ø> (-0.01%) ⬇️
OS-Linux 98.34% <ø> (-0.01%) ⬇️
OS-Windows 96.50% <ø> (ø)
OS-macOS 97.49% <ø> (-0.01%) ⬇️
Py-3.10.11 97.39% <ø> (ø)
Py-3.10.17 97.92% <ø> (-0.01%) ⬇️
Py-3.11.12 98.00% <ø> (ø)
Py-3.11.9 97.46% <ø> (-0.01%) ⬇️
Py-3.12.10 98.41% <ø> (ø)
Py-3.13.3 98.40% <ø> (+0.26%) ⬆️
Py-3.9.13 97.26% <ø> (ø)
Py-3.9.22 97.78% <ø> (ø)
Py-pypy7.3.16 83.11% <ø> (-2.28%) ⬇️
VM-macos 97.49% <ø> (-0.01%) ⬇️
VM-ubuntu 98.34% <ø> (-0.01%) ⬇️
VM-windows 96.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10913 will improve performances by 10.16%

Comparing remove_mock_coro (5803134) with master (36a2567)

Summary

⚡ 1 improvements
✅ 59 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_ten_streamed_responses_iter_any[pyloop] 23.6 ms 21.4 ms +10.16%

@bdraco bdraco added the backport:skip Skip backport bot label May 20, 2025
@bdraco bdraco marked this pull request as ready for review May 20, 2025 21:59
@bdraco bdraco requested review from webknjaz and asvetlov as code owners May 20, 2025 21:59
@bdraco bdraco merged commit b58c3ad into master May 20, 2025
40 of 42 checks passed
@bdraco bdraco deleted the remove_mock_coro branch May 20, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant