[PR #10910/36a2567 backport][3.12] Remove mocked coro from tests #10914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
the
bot:chronographer:skip
bdraco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #10914 +/- ##
==========================================
- Coverage 98.16% 98.14% -0.02%
==========================================
Files 130 130
Lines 39296 39279 -17
Branches 2220 2220
==========================================
- Hits 38573 38552 -21
- Misses 552 554 +2
- Partials 171 173 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10914 will not alter performanceComparing Summary
|
bdraco
deleted the
patchback/backports/3.12/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of 36a2567,
make_mocked_corois still left in the test utils for backwards compat, and only the internal tests are updated.(cherry picked from commit 36a2567)