-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Winloop to test suite if User is using Windows #10922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Winloop to test suite if User is using Windows #10922
Conversation
Please Know that I do not wish to give my real name in the contributors list for my own safety. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10922 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 129 129
Lines 39072 39097 +25
Branches 2164 2167 +3
=======================================
+ Hits 38586 38611 +25
Misses 337 337
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10922 will not alter performanceComparing Summary
|
Please add a contrib changelog note. Thanks! |
@bdraco Thanks for the feedback, Added :) |
You'll need to update requirements/base.in as well |
Alright. Give me a few seconds to do this 👍 |
should work let me know if "cpython" should or shouldn't be recommended. |
Looks like the ci doesn't like testsuite as a single word. You will need to add winloop to the docs spelling word list to get that one to pass |
Shouldn't be too bad how should I approach changing it? |
Add |
@bdraco Thanks for your help :) |
@bdraco Seems the workflow passed successfully is there anything else I should do? |
I'll check it again after some sleep |
Co-authored-by: Sam Bull <[email protected]>
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10930 🤖 @patchback |
Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 5fac5f1)
Thanks @Vizonex |
Your welcome glad I could be able to contribute, I have some very unique plans to make aiohttp better in the future and this was just the start. |
… is using Windows (#10930) Co-authored-by: Vizonex <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Sam Bull <[email protected]>
What do these changes do?
Felt that winloop should be added because I made it for supporting uvloop on windows operating systems.
Are there changes in behavior for the user?
Adds winloop to the test-suite which should hopefully allow me and other maintainers to fix more bugs in the future.
Is it a substantial burden for the maintainers to support this?
Really it shouldn't be too much of a burden to maintain this new addition since If it's winloop's fault you can always throw the issue on our github. I'm also looking for maintainers with my current project so that it will outlive the time I have planned to spend maintaining it, currently I am the only active maintainer since the other maintainer we had seems to have gone silent since our last release.
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.