Skip to content

Add Winloop to test suite if User is using Windows #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Vizonex
Copy link
Contributor

@Vizonex Vizonex commented May 21, 2025

What do these changes do?

Felt that winloop should be added because I made it for supporting uvloop on windows operating systems.

Are there changes in behavior for the user?

Adds winloop to the test-suite which should hopefully allow me and other maintainers to fix more bugs in the future.

Is it a substantial burden for the maintainers to support this?

Really it shouldn't be too much of a burden to maintain this new addition since If it's winloop's fault you can always throw the issue on our github. I'm also looking for maintainers with my current project so that it will outlive the time I have planned to spend maintaining it, currently I am the only active maintainer since the other maintainer we had seems to have gone silent since our last release.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@Vizonex Vizonex requested review from webknjaz and asvetlov as code owners May 21, 2025 20:55
@Vizonex
Copy link
Contributor Author

Vizonex commented May 21, 2025

Please Know that I do not wish to give my real name in the contributors list for my own safety.

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (b58c3ad) to head (451d80e).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10922   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         129      129           
  Lines       39072    39097   +25     
  Branches     2164     2167    +3     
=======================================
+ Hits        38586    38611   +25     
  Misses        337      337           
  Partials      149      149           
Flag Coverage Δ
CI-GHA 98.63% <66.66%> (-0.01%) ⬇️
OS-Linux 98.34% <33.33%> (-0.01%) ⬇️
OS-Windows 96.49% <33.33%> (-0.02%) ⬇️
OS-macOS 97.49% <33.33%> (-0.01%) ⬇️
Py-3.10.11 97.38% <66.66%> (-0.01%) ⬇️
Py-3.10.17 97.92% <33.33%> (-0.01%) ⬇️
Py-3.11.12 97.99% <33.33%> (-0.02%) ⬇️
Py-3.11.9 97.46% <66.66%> (-0.02%) ⬇️
Py-3.12.10 98.41% <66.66%> (-0.01%) ⬇️
Py-3.13.3 98.39% <66.66%> (-0.01%) ⬇️
Py-3.9.13 97.25% <66.66%> (-0.01%) ⬇️
Py-3.9.22 97.78% <33.33%> (-0.01%) ⬇️
Py-pypy7.3.16 84.37% <33.33%> (-8.58%) ⬇️
VM-macos 97.49% <33.33%> (-0.01%) ⬇️
VM-ubuntu 98.34% <33.33%> (-0.01%) ⬇️
VM-windows 96.49% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Performance Report

Merging #10922 will not alter performance

Comparing Vizonex:add-winloop-to-testsuite-if-using-windows (451d80e) with master (19643c9)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label May 21, 2025
@bdraco
Copy link
Member

bdraco commented May 21, 2025

Please add a contrib changelog note.

Thanks!

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 22, 2025
@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

Please add a contrib changelog note.

Thanks!

@bdraco Thanks for the feedback, Added :)

@bdraco
Copy link
Member

bdraco commented May 22, 2025

You'll need to update requirements/base.in as well

@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

You'll need to update requirements/base.in as well

Alright. Give me a few seconds to do this 👍

@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

should work let me know if "cpython" should or shouldn't be recommended.

@bdraco
Copy link
Member

bdraco commented May 22, 2025

Looks like the ci doesn't like testsuite as a single word.

You will need to add winloop to the docs spelling word list to get that one to pass

@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

Looks like the ci doesn't like testsuite as a single word.

You will need to add winloop to the docs spelling word list to get that one to pass

Shouldn't be too bad how should I approach changing it?

@Vizonex Vizonex changed the title Add Winloop to testsuite if User is using Windows Add Winloop to test suite if User is using Windows May 22, 2025
@bdraco
Copy link
Member

bdraco commented May 22, 2025

Looks like the ci doesn't like testsuite as a single word.
You will need to add winloop to the docs spelling word list to get that one to pass

Shouldn't be too bad how should I approach changing it?

Add winloop into docs/spelling_wordlist.txt at the right lexicographic order

@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

@bdraco Thanks for your help :)

@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

@bdraco Seems the workflow passed successfully is there anything else I should do?

@bdraco
Copy link
Member

bdraco commented May 22, 2025

I'll check it again after some sleep

@bdraco bdraco enabled auto-merge (squash) May 22, 2025 14:26
@bdraco bdraco merged commit 5fac5f1 into aio-libs:master May 22, 2025
40 checks passed
Copy link
Contributor

patchback bot commented May 22, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/5fac5f1988d294ab811318face9dda67602bb923/pr-10922

Backported as #10930

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 22, 2025
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 5fac5f1)
@bdraco
Copy link
Member

bdraco commented May 22, 2025

Thanks @Vizonex

@Vizonex
Copy link
Contributor Author

Vizonex commented May 22, 2025

Thanks @Vizonex

Your welcome glad I could be able to contribute, I have some very unique plans to make aiohttp better in the future and this was just the start.

bdraco added a commit that referenced this pull request May 22, 2025
… is using Windows (#10930)

Co-authored-by: Vizonex <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants