Skip to content

[PR #10915/545783b backport][3.12] Fix connection reuse for file-like data payloads #10931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

(cherry picked from commit 545783b)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 22, 2025
@bdraco bdraco changed the title Fix connection reuse for file-like data payloads (#10915) [PR #10915/545783b backport][3.12] Fix connection reuse for file-like data payloads May 22, 2025
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10931 will not alter performance

Comparing patchback/backports/3.12/545783b9e91c69d48ffd3b85c7eb13d1b19eb55e/pr-10915 (cd1e9a4) with 3.12 (10f0cf8)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review May 22, 2025 15:18
@bdraco bdraco requested review from webknjaz and asvetlov as code owners May 22, 2025 15:18
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (10f0cf8) to head (cd1e9a4).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10931      +/-   ##
==========================================
+ Coverage   98.15%   98.16%   +0.01%     
==========================================
  Files         130      130              
  Lines       39304    39652     +348     
  Branches     2223     2240      +17     
==========================================
+ Hits        38577    38925     +348     
- Misses        554      555       +1     
+ Partials      173      172       -1     
Flag Coverage Δ
CI-GHA 98.05% <100.00%> (+0.01%) ⬆️
OS-Linux 97.78% <100.00%> (+0.01%) ⬆️
OS-Windows 95.26% <100.00%> (+0.04%) ⬆️
OS-macOS 96.95% <99.75%> (+0.01%) ⬆️
Py-3.10.11 96.83% <99.75%> (+0.02%) ⬆️
Py-3.10.17 97.38% <100.00%> (+0.02%) ⬆️
Py-3.11.12 97.44% <100.00%> (-0.02%) ⬇️
Py-3.11.9 96.93% <99.75%> (+0.02%) ⬆️
Py-3.12.10 97.84% <100.00%> (+0.01%) ⬆️
Py-3.13.3 97.83% <100.00%> (+0.02%) ⬆️
Py-3.9.13 96.72% <99.75%> (+0.01%) ⬆️
Py-3.9.22 97.26% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 88.75% <99.75%> (+4.46%) ⬆️
VM-macos 96.95% <99.75%> (+0.01%) ⬆️
VM-ubuntu 97.78% <100.00%> (+0.01%) ⬆️
VM-windows 95.26% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) May 22, 2025 15:22
@bdraco bdraco merged commit 0c16102 into 3.12 May 22, 2025
49 of 65 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/545783b9e91c69d48ffd3b85c7eb13d1b19eb55e/pr-10915 branch May 22, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant