Skip to content

Fix flakey test_normal_closure_while_client_sends_msg test #10932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Fix flakey test_normal_closure_while_client_sends_msg test #10932

merged 1 commit into from
May 22, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025 •
edited
Loading

SSIA

@bdraco bdraco requested a review from asvetlov as a code owner May 22, 2025 15:24
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels May 22, 2025
@bdraco bdraco enabled auto-merge (squash) May 22, 2025 15:32
@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (19643c9) to head (b8baebe).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10932      +/-   ##
==========================================
+ Coverage   98.75%   98.77%   +0.01%     
==========================================
  Files         129      129              
  Lines       39095    39455     +360     
  Branches     2166     2184      +18     
==========================================
+ Hits        38609    38970     +361     
  Misses        337      337              
+ Partials      149      148       -1
Flag Coverage Δ
CI-GHA 98.65% <100.00%> (+0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+0.01%) ⬆️
OS-Windows 96.54% <100.00%> (+0.03%) ⬆️
OS-macOS 97.51% <100.00%> (+0.01%) ⬆️
Py-3.10.11 97.40% <100.00%> (+0.01%) ⬆️
Py-3.10.17 97.94% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 98.02% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.48% <100.00%> (+0.01%) ⬆️
Py-3.12.10 98.42% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 98.41% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.29% <100.00%> (+0.02%) ⬆️
Py-3.9.22 97.81% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 93.36% <100.00%> (+3.40%) ⬆️
VM-macos 97.51% <100.00%> (+0.01%) ⬆️
VM-ubuntu 98.36% <100.00%> (+0.01%) ⬆️
VM-windows 96.54% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10932 will not alter performance

Comparing flakey_websocket_test (b8baebe) with master (545783b)

Summary

✅ 59 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented May 22, 2025

of course a different test flakes 😄

#10933

@bdraco bdraco merged commit 6b3672f into master May 22, 2025
66 of 72 checks passed
@bdraco bdraco deleted the flakey_websocket_test branch May 22, 2025 15:46
@patchback Patchback
Copy link
Contributor

patchback bot commented May 22, 2025 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/6b3672f08aeb1575f84e81b4de8fb5a8caa07043/pr-10932

Backported as #10934

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 22, 2025
@bdraco @patchback
Fix flakey test_normal_closure_while_client_sends_msg test (#10932)
d01cacc 
(cherry picked from commit 6b3672f)
@patchback Patchback
Copy link
Contributor

patchback bot commented May 22, 2025 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/6b3672f08aeb1575f84e81b4de8fb5a8caa07043/pr-10932

Backported as #10935

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request May 22, 2025
Merged
patchback bot pushed a commit that referenced this pull request May 22, 2025
@bdraco @patchback
Fix flakey test_normal_closure_while_client_sends_msg test (#10932)
45ee653 
(cherry picked from commit 6b3672f)
@patchback patchback bot mentioned this pull request May 22, 2025
Merged
bdraco added a commit that referenced this pull request May 22, 2025
@patchback @bdraco
[PR #10932/6b3672f0 backport][3.12] Fix flakey test_normal_closure_wh…
11aaa23 
…ile_client_sends_msg test (#10935)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request May 22, 2025
@patchback @bdraco
[PR #10932/6b3672f0 backport][3.11] Fix flakey test_normal_closure_wh…
ab84403 
…ile_client_sends_msg test (#10934)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco