Skip to content

[PR #10933/597161d backport][3.12] Fix flakey client functional keep alive tests #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

(cherry picked from commit 597161d)

@bdraco bdraco changed the title Fix flakey client functional keep alive tests (#10933) [PR #10933/597161d backport][3.12] Fix flakey client functional keep alive tests May 22, 2025
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label May 22, 2025
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10937 will not alter performance

Comparing patchback/backports/3.12/597161d1127d04e7842642d7548d4bd8de3115a6/pr-10933 (cfda266) with 3.12 (0c16102)

Summary

✅ 59 untouched benchmarks

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (0c16102) to head (cfda266).
Report is 2 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10937   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         130      130           
  Lines       39652    39652           
  Branches     2240     2240           
=======================================
  Hits        38925    38925           
  Misses        555      555           
  Partials      172      172           
Flag Coverage Δ
CI-GHA 98.05% <100.00%> (ø)
OS-Linux 97.78% <100.00%> (ø)
OS-Windows 95.26% <100.00%> (ø)
OS-macOS 96.95% <100.00%> (ø)
Py-3.10.11 96.84% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.37% <100.00%> (-0.01%) ⬇️
Py-3.11.12 97.48% <57.14%> (+0.04%) ⬆️
Py-3.11.9 96.93% <57.14%> (-0.01%) ⬇️
Py-3.12.10 97.84% <100.00%> (ø)
Py-3.13.3 97.83% <100.00%> (ø)
Py-3.9.13 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.25% <100.00%> (ø)
Py-pypy7.3.16 82.29% <100.00%> (-6.35%) ⬇️
VM-macos 96.95% <100.00%> (ø)
VM-ubuntu 97.78% <100.00%> (ø)
VM-windows 95.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review May 22, 2025 16:35
@bdraco bdraco requested a review from asvetlov as a code owner May 22, 2025 16:35
@bdraco bdraco enabled auto-merge (squash) May 22, 2025 16:35
@bdraco bdraco merged commit 38c23ed into 3.12 May 22, 2025
59 of 65 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/597161d1127d04e7842642d7548d4bd8de3115a6/pr-10933 branch May 22, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant