Skip to content

Fix flakey test_content_length_limit_with_multiple_reads test #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

SSIA

@bdraco bdraco requested a review from asvetlov as a code owner May 22, 2025 16:37
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels May 22, 2025
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10938 will not alter performance

Comparing test_content_length_limit_with_multiple_reads (638b3ab) with master (597161d)

Summary

✅ 59 untouched benchmarks

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (6b3672f) to head (638b3ab).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10938   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         129      129           
  Lines       39455    39456    +1     
  Branches     2184     2184           
=======================================
+ Hits        38970    38971    +1     
  Misses        337      337           
  Partials      148      148           
Flag Coverage Δ
CI-GHA 98.65% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.54% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.40% <100.00%> (-0.01%) ⬇️
Py-3.10.17 97.94% <100.00%> (-0.01%) ⬇️
Py-3.11.12 98.02% <100.00%> (+0.04%) ⬆️
Py-3.11.9 97.48% <100.00%> (-0.01%) ⬇️
Py-3.12.10 98.42% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 98.41% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.80% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 93.53% <100.00%> (-3.84%) ⬇️
VM-macos 97.51% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.36% <100.00%> (+<0.01%) ⬆️
VM-windows 96.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) May 22, 2025 16:53
@bdraco bdraco merged commit 77c0115 into master May 22, 2025
42 checks passed
@bdraco bdraco deleted the test_content_length_limit_with_multiple_reads branch May 22, 2025 16:54
Copy link
Contributor

patchback bot commented May 22, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/77c0115eb878ad797cc6ac127001fdaa7f3efc40/pr-10938

Backported as #10939

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 22, 2025
bdraco added a commit that referenced this pull request May 22, 2025
…mit_with_multiple_reads test (#10939)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant