Skip to content

[PR #10946/3c88f811 backport][3.12] Ensure AsyncResolver.close() can be called multiple times #10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 22, 2025

This is a backport of PR #10946 as merged into master (3c88f81).

regressed in #10847 but never in a stable release so I linked the changelog message instead of adding a bugfix.

@bdraco bdraco enabled auto-merge (squash) May 22, 2025 19:44
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10947 will not alter performance

Comparing patchback/backports/3.12/3c88f811390cebf524281bebfdbd807a57ab855e/pr-10946 (9817c0e) with 3.12 (9bd43ed)

Summary

✅ 59 untouched benchmarks

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (9bd43ed) to head (9817c0e).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10947   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         130      130           
  Lines       39655    39675   +20     
  Branches     2241     2242    +1     
=======================================
+ Hits        38928    38948   +20     
  Misses        555      555           
  Partials      172      172           
Flag Coverage Δ
CI-GHA 98.05% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.77% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.26% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.37% <100.00%> (-0.01%) ⬇️
Py-3.11.12 97.47% <100.00%> (-0.01%) ⬇️
Py-3.11.9 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.25% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 82.70% <100.00%> (-4.62%) ⬇️
VM-macos 96.94% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.77% <100.00%> (+<0.01%) ⬆️
VM-windows 95.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 1f1bc8f into 3.12 May 22, 2025
35 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/3c88f811390cebf524281bebfdbd807a57ab855e/pr-10946 branch May 22, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant