Skip to content

Improve connection reuse test coverage #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Improve connection reuse test coverage #10949

merged 2 commits into from
May 22, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

I'm planning on removing .release() from the examples and the digest middleware. I wanted to make sure everything is working correctly before I proceed with that.

@bdraco bdraco requested a review from asvetlov as a code owner May 22, 2025 20:59
@bdraco bdraco added this to the 3.12 milestone May 22, 2025
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (3c88f81) to head (08c29c2).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10949   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         129      129           
  Lines       39478    39539   +61     
  Branches     2186     2186           
=======================================
+ Hits        38993    39054   +61     
  Misses        337      337           
  Partials      148      148           
Flag Coverage Δ
CI-GHA 98.65% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.54% <100.00%> (+0.01%) ⬆️
OS-macOS 97.51% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.94% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 98.02% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.48% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 98.42% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 98.41% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.29% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.80% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 93.15% <100.00%> (-4.23%) ⬇️
VM-macos 97.51% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.36% <100.00%> (+<0.01%) ⬆️
VM-windows 96.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10949 will not alter performance

Comparing connection_reuse_tests (08c29c2) with master (3c88f81)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco merged commit 06e3b36 into master May 22, 2025
40 checks passed
@bdraco bdraco deleted the connection_reuse_tests branch May 22, 2025 21:39
Copy link
Contributor

patchback bot commented May 22, 2025

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 06e3b36 on top of patchback/backports/3.12/06e3b3682c72ffa56b48087cf9b05b3f71f95ab1/pr-10949

Backporting merged PR #10949 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.12/06e3b3682c72ffa56b48087cf9b05b3f71f95ab1/pr-10949 upstream/3.12
  4. Now, cherry-pick PR Improve connection reuse test coverage #10949 contents into that branch:
    $ git cherry-pick -x 06e3b3682c72ffa56b48087cf9b05b3f71f95ab1
    If it'll yell at you with something like fatal: Commit 06e3b3682c72ffa56b48087cf9b05b3f71f95ab1 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 06e3b3682c72ffa56b48087cf9b05b3f71f95ab1
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Improve connection reuse test coverage #10949 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.12/06e3b3682c72ffa56b48087cf9b05b3f71f95ab1/pr-10949
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant